[PATCH 0/1] MR1213: shell32: Prevent double free (Coverity)

[Fabian Maurer (＠DarkShadow44)]

If we get an error, we might get a double free otherwise.

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de>

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1213

[PATCH 1/1] shell32: Prevent double free (Coverity)

[Fabian Maurer]

From: Fabian Maurer <dark.shadow4(a)web.de>

If we get an error, we might get a double free otherwise.

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de>
---
 dlls/shell32/dde.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/shell32/dde.c b/dlls/shell32/dde.c
index 24482d2c33f..96b5a243f93 100644
--- a/dlls/shell32/dde.c
+++ b/dlls/shell32/dde.c
@@ -403,6 +403,7 @@ static DWORD parse_dde_command(HSZ hszTopic, WCHAR *command)
         }
 
         free(opcode);
+        opcode = NULL;
         for (i = 0; i < argc; i++) free(argv[i]);
         free(argv);
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1213

[PATCH 1/1] shell32: Prevent double free (Coverity)

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=125631

Your paranoid android.


=== debian11 (32 bit zh:CN report) ===

shell32:
autocomplete.c:614: Test failed: Expected (null), got L"ab"
autocomplete.c:637: Test failed: Expected (null), got L"www.ax"