[PATCH 0/1] MR5981: msi: Initialize size argument to GetRegValueW.

[Alex Henrie (＠alexhenrie)]

Split from !5969

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5981

[PATCH 1/1] msi: Initialize size argument to GetRegValueW.

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

---
 dlls/msi/registry.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/msi/registry.c b/dlls/msi/registry.c
index 149f9cf9945..ad220eaa756 100644
--- a/dlls/msi/registry.c
+++ b/dlls/msi/registry.c
@@ -1846,6 +1846,7 @@ static UINT check_product_patches(const WCHAR *prodcode, const WCHAR *usersid, M
                 RegOpenKeyExW(localprod, L"Patches", 0, KEY_READ, &localpatch) == ERROR_SUCCESS &&
                 RegOpenKeyExW(localpatch, ptr, 0, KEY_READ, &patchkey) == ERROR_SUCCESS)
             {
+                size = sizeof(state);
                 res = RegGetValueW(patchkey, NULL, L"State", RRF_RT_REG_DWORD,
                                    &type, &state, &size);
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5981

[PATCH 1/1] msi: Initialize size argument to GetRegValueW.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=146786

Your paranoid android.


=== debian11b (64 bit WoW report) ===

kernel32:
comm.c:1574: Test failed: AbortWaitCts hComPortEvent failed
comm.c:1586: Test failed: Unexpected time 1001, expected around 500

user32:
input.c:4305: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 0000000000F900EE, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032