[PATCH 0/1] MR4788: ntdll: Include alloc_type argument in NtMapViewOfSection(Ex) traces.

[Alex Henrie (＠alexhenrie)]

LANCommander calls NtMapViewOfSectionEx with alloc_type=0x4000, which
Wine does not handle, but you couldn't tell from the trace.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4788

[PATCH 1/1] ntdll: Include alloc_type argument in NtMapViewOfSection(Ex) traces.

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

LANCommander calls NtMapViewOfSectionEx with alloc_type=0x4000, which
Wine does not handle, but you couldn't tell from the trace.
---
 dlls/ntdll/unix/virtual.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/ntdll/unix/virtual.c b/dlls/ntdll/unix/virtual.c
index abe1b4dc4ec..09ed98af684 100644
--- a/dlls/ntdll/unix/virtual.c
+++ b/dlls/ntdll/unix/virtual.c
@@ -5439,8 +5439,8 @@ NTSTATUS WINAPI NtMapViewOfSection( HANDLE handle, HANDLE process, PVOID *addr_p
 
     offset.QuadPart = offset_ptr ? offset_ptr->QuadPart : 0;
 
-    TRACE("handle=%p process=%p addr=%p off=%s size=%lx access=%x\n",
-          handle, process, *addr_ptr, wine_dbgstr_longlong(offset.QuadPart), *size_ptr, (int)protect );
+    TRACE("handle=%p process=%p addr=%p off=%s size=0x%lx alloc_type=0x%x access=0x%x\n",
+          handle, process, *addr_ptr, wine_dbgstr_longlong(offset.QuadPart), *size_ptr, alloc_type, (int)protect );
 
     /* Check parameters */
     if (zero_bits > 21 && zero_bits < 32)
@@ -5517,8 +5517,8 @@ NTSTATUS WINAPI NtMapViewOfSectionEx( HANDLE handle, HANDLE process, PVOID *addr
 
     offset.QuadPart = offset_ptr ? offset_ptr->QuadPart : 0;
 
-    TRACE( "handle=%p process=%p addr=%p off=%s size=%lx access=%x\n",
-           handle, process, *addr_ptr, wine_dbgstr_longlong(offset.QuadPart), *size_ptr, (int)protect );
+    TRACE( "handle=%p process=%p addr=%p off=%s size=0x%lx alloc_type=0x%x access=0x%x\n",
+           handle, process, *addr_ptr, wine_dbgstr_longlong(offset.QuadPart), *size_ptr, alloc_type, (int)protect );
 
     status = get_extended_params( parameters, count, &limit_low, &limit_high,
                                   &align, &attributes, &machine );
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4788

[PATCH 1/1] ntdll: Include alloc_type argument in NtMapViewOfSection(Ex) traces.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=141622

Your paranoid android.


=== debian11b (64 bit WoW report) ===

d3d10core:
d3d10core: Timeout