[PATCH 0/1] MR1218: msvcrt/tests: Fix typo (Coverity)

[Fabian Maurer (＠DarkShadow44)]

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de>

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1218

[PATCH 1/1] msvcrt/tests: Fix typo (Coverity)

[Fabian Maurer]

From: Fabian Maurer <dark.shadow4(a)web.de>

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de>
---
 dlls/msvcrt/tests/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msvcrt/tests/file.c b/dlls/msvcrt/tests/file.c
index 78ed8931d7a..7188ade5cdb 100644
--- a/dlls/msvcrt/tests/file.c
+++ b/dlls/msvcrt/tests/file.c
@@ -1935,7 +1935,7 @@ static void test_fopen_fclose_fcloseall( void )
     ok(errno == 0xdeadbeef, "errno = %d\n", errno);
     ret = fclose(NULL);
     ok(ret == EOF, "Closing NULL file returned %d\n", ret);
-    ok(errno = EINVAL, "errno = %d\n", errno);
+    ok(errno == EINVAL, "errno = %d\n", errno);
 
     /* testing fcloseall() */
     numclosed = _fcloseall();
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1218

[Piotr Caban (＠piotr)]

It looks like your repository is somehow hidden. It prevents the pipeline from executing. The patch looks good but it would be good to see that the tests are passing on gitlab. Could you please try to do something with it?

When I try to fetch the the commit I get following error message:
```
#git fetch "git(a)gitlab.winehq.org:DarkShadow44/wine.git" 'msvcrt-coverity'

remote: 
remote: ========================================================================
remote: 
remote: The project you were looking for could not be found or you don't have permission to view it.
remote: 
remote: ========================================================================
remote: 
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
```

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1218#note_12731

[Fabian Maurer (＠DarkShadow44)]

I changed the visibility, does it work now?
Also, this should be the corresponding pipeline: https://gitlab.winehq.org/DarkShadow44/wine/-/pipelines/3582

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1218#note_12778

[Piotr Caban (＠piotr)]

On Wed Nov  2 12:57:24 2022 +0000, Fabian Maurer wrote:
> I changed the visibility, does it work now?
> Also, this should be the corresponding pipeline: https://gitlab.winehq.org/DarkShadow44/wine/-/pipelines/3582
> Yes, it works now. Thank you.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1218#note_12779

[PATCH 0/1] MR1218: msvcrt/tests: Fix typo (Coverity) - approved

[Piotr Caban (＠piotr)]

This merge request was approved by Piotr Caban.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1218