[PATCH v2 0/1] MR935: widl: Generate "static inline" instead of "static FORCEINLINE" for COM inline wrappers.

[Zebediah Figura (＠zfigura)]

mingw-w64 defines __forceinline (and therefore FORCEINLINE) as
"extern __inline__ __attribute__((__always_inline__,__gnu_inline__)). This means
that COM inline wrappers specify multiple storage classes and hence cannot be
compiled.

Wine defines FORCEINLINE simply as "inline" (and uses "static" everywhere), so
this is a non-issue for Wine. However, since Wine and mingw-w64 share the source
code of widl and of most IDL headers, this patch changes the definition for both
projects.

There's no reason to force inlining here, especially since the wrappers need to
be manually enabled, and we don't need to match PSDK semantics where these
wrappers don't even exist.

In practice, use "__inline__" instead of "inline" for GNU C targets, to preserve
compatibility with C89 in mingw-w64 headers.

--
  v2: widl: Generate "static inline" instead of "static FORCEINLINE" for COM inline wrappers.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/935

[PATCH v2 1/1] widl: Generate "static inline" instead of "static FORCEINLINE" for COM inline wrappers.

[Zebediah Figura]

From: Zebediah Figura <zfigura(a)codeweavers.com>

mingw-w64 defines __forceinline (and therefore FORCEINLINE) as
"extern __inline__ __attribute__((__always_inline__,__gnu_inline__)). This means
that COM inline wrappers specify multiple storage classes and hence cannot be
compiled.

Wine defines FORCEINLINE simply as "inline" (and uses "static" everywhere), so
this is a non-issue for Wine. However, since Wine and mingw-w64 share the source
code of widl and of most IDL headers, this patch changes the definition for both
projects.

There's no reason to force inlining here, especially since the wrappers need to
be manually enabled, and we don't need to match PSDK semantics where these
wrappers don't even exist.

In practice, use "__inline__" instead of "inline" for GNU C targets, to preserve
compatibility with C89 in mingw-w64 headers.
---
 tools/widl/header.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/tools/widl/header.c b/tools/widl/header.c
index 8b9c64e1e38..35163bfa86b 100644
--- a/tools/widl/header.c
+++ b/tools/widl/header.c
@@ -1315,7 +1315,7 @@ static void write_inline_wrappers(FILE *header, const type_t *iface, const type_
     if (!is_callas(func->attrs)) {
       const var_t *arg;
 
-      fprintf(header, "static FORCEINLINE ");
+      fprintf(header, "static __WIDL_INLINE ");
       write_type_decl_left(header, type_function_get_ret(func->declspec.type));
       fprintf(header, " %s_%s(", name, get_name(func));
       write_args(header, type_function_get_args(func->declspec.type), name, 1, FALSE, NAME_C);
@@ -2155,6 +2155,14 @@ void write_header(const statement_list_t *stmts)
   fprintf(header, "#ifndef __%s__\n", header_token);
   fprintf(header, "#define __%s__\n\n", header_token);
 
+  fprintf(header, "#ifndef __WIDL_INLINE\n");
+  fprintf(header, "#if defined(__cplusplus) || defined(_MSC_VER)\n");
+  fprintf(header, "#define __WIDL_INLINE inline\n");
+  fprintf(header, "#elif defined(__GNUC__)\n");
+  fprintf(header, "#define __WIDL_INLINE __inline__\n");
+  fprintf(header, "#endif\n");
+  fprintf(header, "#endif\n\n");
+
   fprintf(header, "/* Forward declarations */\n\n");
   write_forward_decls(header, stmts);
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/935

[PATCH v2 0/1] MR935: widl: Generate "static inline" instead of "static FORCEINLINE" for COM inline wrappers. - approved

[Huw Davies (＠huw)]

This merge request was approved by Huw Davies.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/935

[PATCH v2 0/1] MR935: widl: Generate "static inline" instead of "static FORCEINLINE" for COM inline wrappers. - approved

[Rémi Bernon]

This merge request was approved by Rémi Bernon.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/935