[PATCH v2 0/1] MR6285: shell32: Allow FindExecutables to find unix files.

[Alistair Leslie-Hughes (＠alesliehughes)]

This fixes one of the regression with ShellExecute when using a full patch and an executable without an extension.

--
  v2: shell32: Allow FindExecutables to find unix files.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6285

[PATCH v2 1/1] shell32: Allow FindExecutables to find unix files.

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>

---
 dlls/shell32/shlexec.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/dlls/shell32/shlexec.c b/dlls/shell32/shlexec.c
index 828c7168a34..52e90b03b0d 100644
--- a/dlls/shell32/shlexec.c
+++ b/dlls/shell32/shlexec.c
@@ -677,7 +677,15 @@ static UINT SHELL_FindExecutable(LPCWSTR lpPath, LPCWSTR lpFile, LPCWSTR lpVerb,
             /* The file was found in lpPath or one of the directories in the system-wide search path */
         }
         else
-            xlpFile[0] = '\0';
+        {
+            /* Checking for an unix application */
+            if( (xlpFile[0] == '/') || PathFindOnPathW(xlpFile, search_paths))
+            {
+                lstrcpyW(lpResult, xlpFile);
+            }
+            else
+                xlpFile[0] = '\0';
+        }
     }
 
     attribs = GetFileAttributesW(lpFile);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6285

[PATCH v2 1/1] shell32: Allow FindExecutables to find unix files.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=148099

Your paranoid android.


=== debian11b (64 bit WoW report) ===

wshom.ocx:
wshom.c:287: Test failed: Unexpected retval 0.