[PATCH 0/1] MR2202: msxml3: Use the _recalloc function instead of reimplementing it.

[Alex Henrie (＠alexhenrie)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2202

[PATCH 1/1] msxml3: Use the _recalloc function instead of reimplementing it.

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

---
 dlls/msxml3/saxreader.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/dlls/msxml3/saxreader.c b/dlls/msxml3/saxreader.c
index 0e886a2d051..9a9a285bd6f 100644
--- a/dlls/msxml3/saxreader.c
+++ b/dlls/msxml3/saxreader.c
@@ -1461,15 +1461,13 @@ static HRESULT SAXAttributes_populate(saxlocator *locator,
     if(locator->attr_count > locator->attr_alloc_count)
     {
         int new_size = locator->attr_count * 2;
-        attrs = realloc(locator->attributes, new_size * sizeof(*locator->attributes));
+        attrs = _recalloc(locator->attributes, new_size, sizeof(*locator->attributes));
         if(!attrs)
         {
             free_attribute_values(locator);
             locator->attr_count = 0;
             return E_OUTOFMEMORY;
         }
-        memset(attrs + locator->attr_alloc_count, 0,
-                (new_size - locator->attr_alloc_count) * sizeof(*locator->attributes));
         locator->attributes = attrs;
         locator->attr_alloc_count = new_size;
     }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2202

[Nikolay Sivov (＠nsivov)]

Similarly to https://gitlab.winehq.org/wine/wine/-/merge_requests/2197#note_24303, I don't like this change, because we might want to switch to "correct" crt at some point.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2202#note_24348

[PATCH 0/1] MR2202: msxml3: Use the _recalloc function instead of reimplementing it. - closed

[Alex Henrie (＠alexhenrie)]

This merge request was closed by Alex Henrie.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2202

[Alex Henrie (＠alexhenrie)]

Closing, see merge request !2197

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2202#note_24627