[PATCH 0/1] MR3000: vbscript: Fix memory leak on error path in alloc_vbscode (scan-build).

[Alex Henrie (＠alexhenrie)]

release_vbscode doesn't do anything if ref is 0.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3000

[PATCH 1/1] vbscript: Fix memory leak on error path in alloc_vbscode (scan-build).

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

release_vbscode doesn't do anything if ref is 0.
---
 dlls/vbscript/compile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/vbscript/compile.c b/dlls/vbscript/compile.c
index 1012f6af469..f86ecfded91 100644
--- a/dlls/vbscript/compile.c
+++ b/dlls/vbscript/compile.c
@@ -1951,6 +1951,7 @@ static vbscode_t *alloc_vbscode(compile_ctx_t *ctx, const WCHAR *source, DWORD_P
         memcpy(ret->source, source, len * sizeof(WCHAR));
     ret->source[len] = 0;
 
+    ret->ref = 1;
     ret->cookie = cookie;
     ret->start_line = start_line;
 
@@ -1966,7 +1967,6 @@ static vbscode_t *alloc_vbscode(compile_ctx_t *ctx, const WCHAR *source, DWORD_P
 
     ret->main_code.type = FUNC_GLOBAL;
     ret->main_code.code_ctx = ret;
-    ret->ref = 1;
 
     list_init(&ret->entry);
     return ret;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3000

[PATCH 1/1] vbscript: Fix memory leak on error path in alloc_vbscode (scan-build).

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=133529

Your paranoid android.


=== debian11 (32 bit report) ===

user32:
msg.c:6897: Test failed: SetFocus(hwnd) on a button: 4: the msg 0x0007 was expected, but got msg 0x0005 instead
msg.c:6897: Test failed: SetFocus(hwnd) on a button: 5: the msg 0x0138 was expected, but got msg 0x030f instead
msg.c:6897: Test failed: SetFocus(hwnd) on a button: 6: the msg 0x0111 was expected, but got msg 0x001c instead
msg.c:6897: Test failed: SetFocus(hwnd) on a button: 8: the msg 0x8000 was expected, but got msg 0x0086 instead
msg.c:6897: Test failed: SetFocus(hwnd) on a button: 9: the msg sequence is not complete: expected 0000 - actual 0006

[PATCH 0/1] MR3000: vbscript: Fix memory leak on error path in alloc_vbscode (scan-build). - approved

[Jacek Caban (＠jacek)]

This merge request was approved by Jacek Caban.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3000