Re: [PATCH v2 0/3] MR3344: windowscodecs: support GIF with no color table
17 Jul
2023
17 Jul
'23
8:07 p.m.
Esme Povirk (@madewokherd) commented about dlls/windowscodecs/tests/gifformat.c:
ok(color[1] == 0x00040506, "expected 0x00040506, got %#x\n", color[1]); ok(color[2] == 0xff070809, "expected 0xff070809, got %#x\n", color[2]); ok(color[3] == 0xff0a0b0c, "expected 0xff0a0b0c, got %#x\n", color[3]); + for (i = 4; i < 256; i++) + ok(color[i] == 0xdeadbeef, "expected 0xdeadbeef, got %#x\n", color[i]);
If the IWICPalette has only 4 colors in it, it can be assumed to only return 4 colors. If for some reason we need a test for palettes writing out of bounds (which I don't think we do), that should go in palette.c. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3344#note_39201
962
Age (days ago)
962
Last active (days ago)
0 comments
1 participants
participants (1)
-
Esme Povirk (@madewokherd)