[PATCH v3 0/1] MR2771: winestreamer: Don't set twice the same format in stream description.

[eric pouech (＠epo)]

Prior to 98d209752cee9abd8dc31dfe1f28811066b0b83f, the base type format
wasn't inserted twice in stream format description.
An application (Idol Showdown) fails to play its intro video when the
base type format is duplicated.

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com>

--
  v3: winestreamer: Fix typo.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2771

[PATCH v3 1/1] winestreamer: Fix typo.

[Eric Pouech]

From: Eric Pouech <epouech(a)codeweavers.com>

Introduced in 98d209752cee9abd8dc31dfe1f28811066b0b83f.
An application (Idol Showdown) fails to play its intro video without
this change.

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com>
---
 dlls/winegstreamer/media_source.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/winegstreamer/media_source.c b/dlls/winegstreamer/media_source.c
index 335b617becd..41271585454 100644
--- a/dlls/winegstreamer/media_source.c
+++ b/dlls/winegstreamer/media_source.c
@@ -947,7 +947,7 @@ static HRESULT media_stream_init_desc(struct media_stream *stream)
 
                 if (FAILED(hr = MFCreateMediaType(&iyuv_type)))
                     goto done;
-                if (FAILED(hr = IMFMediaType_CopyAllItems(iyuv_type, (IMFAttributes *)iyuv_type)))
+                if (FAILED(hr = IMFMediaType_CopyAllItems(new_type, (IMFAttributes *)iyuv_type)))
                     goto done;
                 if (FAILED(hr = IMFMediaType_SetGUID(iyuv_type, &MF_MT_SUBTYPE, &MFVideoFormat_IYUV)))
                     goto done;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2771

[eric pouech (＠epo)]

On Wed May 10 09:30:13 2023 +0000, Zebediah Figura wrote:
> There's a spelling error in the patch subject, by the way.
> > An application (Idol Showdown) fails to play its intro video when the
> > base type format is duplicated.
> > It'd be nice to add a regression test duplicating what this application
> > does, if possible.
> > V3 pushed to correct path title.
> > The app has been updated twice since yesterday, and has a new splash video that now works even without this patch (sigh). Didn't keep the failing traces around, so it's a bit hard to write a test case.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2771#note_32417

[Zebediah Figura (＠zfigura)]

> V3 pushed to correct path title.

Amusingly, that's actually not even the one I was thinking of ("winestreamer" instead of "winegstreamer").

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2771#note_32439