[PATCH v3 0/1] MR2413: comctl32: Fix the problem that listview cannot display all files.

[Zhao Yi (＠Zhaoyi)]

Log: The flag that bNoItemMetrics should be reset to TRUE after
    
calling LISTVIEW_DeleteAllItems().

Signed-off-by: Zhao Yi <zhaoyi(a)uniontech.com>

--
  v3: comctl32: Fix the problem that listview cannot display all files.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2413

[PATCH v3 1/1] comctl32: Fix the problem that listview cannot display all files.

[Zhao Yi]

From: Zhao Yi <zhaoyi(a)uniontech.com>

Log: The flag that bNoItemMetrics should be reset to TRUE after
calling LISTVIEW_DeleteAllItems().

Signed-off-by: Zhao Yi <zhaoyi(a)uniontech.com>
---
 dlls/comctl32/listview.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c
index 750e447dbef..026884372aa 100644
--- a/dlls/comctl32/listview.c
+++ b/dlls/comctl32/listview.c
@@ -5590,7 +5590,7 @@ static BOOL LISTVIEW_DeleteAllItems(LISTVIEW_INFO *infoPtr, BOOL destroy)
         LISTVIEW_UpdateScroll(infoPtr);
     }
     LISTVIEW_InvalidateList(infoPtr);
-    
+    infoPtr->bNoItemMetrics = TRUE;
     return TRUE;
 }
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2413

[PATCH v3 1/1] comctl32: Fix the problem that listview cannot display all files.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=130645

Your paranoid android.


=== debian11 (32 bit report) ===

dinput:
device8.c:432: Test failed: 0x800: WaitForSingleObject returned 0x102
device8.c:437: Test failed: 0x800: got count 0
device8.c:452: Test failed: 0x800: WaitForSingleObject returned 0x102
device8.c:457: Test failed: 0x800: got count 0

[Zhiyi Zhang (＠zhiyi)]

In general, we try to be specific about the commit message subject instead of just saying "fix something". You can say "comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems()" in the commit message subject and then in the commit message "Fix 2345 picture viewer not displaying all files."

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2413#note_27111

[Zhao Yi (＠Zhaoyi)]

On Fri Mar 17 08:44:26 2023 +0000, Zhiyi Zhang wrote:
> In general, we try to be specific about the commit message subject
> instead of just saying "fix something". You can say "comctl32/listview:
> Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems()." in the commit
> message subject and then in the commit message body "Fix 2345 picture
> viewer not displaying all files."
> OK, I will modify the commit message as you said later ^V^.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2413#note_27112