[PATCH 0/1] MR1: vkd3d-shader: Initialize counter_var_info unconditionally.
--- It is only set if certain shader properties are met, and Visual Studio rightfully complains that we read an uninitialized variable later. Maybe resource_symbol.info.resource.uav_counter_array is never used later on, but it still is bad style to propagate uninitialized values. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/1
From: Stefan D��singer <stefan(a)codeweavers.com> --- It is only set if certain shader properties are met, and Visual Studio rightfully complains that we read an uninitialized variable later. Maybe resource_symbol.info.resource.uav_counter_array is never used later on, but it still is bad style to propagate uninitialized values. --- libs/vkd3d-shader/spirv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/vkd3d-shader/spirv.c b/libs/vkd3d-shader/spirv.c index 776533cb..c519a2ba 100644 --- a/libs/vkd3d-shader/spirv.c +++ b/libs/vkd3d-shader/spirv.c @@ -5962,7 +5962,7 @@ static void vkd3d_dxbc_compiler_emit_resource_declaration(struct vkd3d_dxbc_comp const struct vkd3d_shader_resource *resource, enum vkd3d_shader_resource_type resource_type, enum vkd3d_data_type resource_data_type, unsigned int structure_stride, bool raw) { - struct vkd3d_descriptor_variable_info var_info, counter_var_info; + struct vkd3d_descriptor_variable_info var_info, counter_var_info = {0}; struct vkd3d_spirv_builder *builder = &compiler->spirv_builder; SpvStorageClass storage_class = SpvStorageClassUniformConstant; uint32_t counter_type_id, type_id, var_id, counter_var_id = 0; -- GitLab https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/1
This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/1
participants (2)
-
Henri Verbeet (＠hverbeet) -
Stefan Dösinger