[PATCH 0/1] MR6345: kernel32: PowerCreateRequest return a valid handle

[Alistair Leslie-Hughes (＠alesliehughes)]

When the application is finished with this handle, CloseHandle
should be used.  This was causing steam to crash when viewing content.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6345

[PATCH 1/1] kernel32: PowerCreateRequest return a valid handle

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>

When the application is finished with this handle, CloseHandle
should be used.  This was causing steam to crash when viewing content.
---
 dlls/kernel32/powermgnt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/kernel32/powermgnt.c b/dlls/kernel32/powermgnt.c
index e7ea54a557c..c4bd97553fe 100644
--- a/dlls/kernel32/powermgnt.c
+++ b/dlls/kernel32/powermgnt.c
@@ -146,7 +146,7 @@ HANDLE WINAPI PowerCreateRequest(REASON_CONTEXT *context)
 {
     FIXME("(%p): stub\n", context);
 
-    return (HANDLE)0xcafecafe;
+    return CreateEventW(NULL, TRUE, FALSE, NULL);
 }
 
 /***********************************************************************
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6345

[PATCH 1/1] kernel32: PowerCreateRequest return a valid handle

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=147954

Your paranoid android.


=== debian11b (64 bit WoW report) ===

user32:
input.c:4305: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 0000000000FF00EC, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032

Report validation errors:
quartz:filtergraph crashed (c0000008)

[Nikolay Sivov (＠nsivov)]

Do you know what exactly was crashing?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6345#note_79729

[Alistair Leslie-Hughes (＠alesliehughes)]

The basic calls are
0160:fixme:powermgnt:PowerCreateRequest (000000000011F280): stub
0160:fixme:powermgnt:PowerSetRequest (00000000CAFECAFE, 0): stub
0160:fixme:powermgnt:PowerClearRequest (00000000CAFECAFE, 0): stub
0160:fixme:process:CloseHandle XXXXXXX: Free 0xcafecafe

The CloseHandle call was causing a crash.  I added check (Handle == 0xCAFECAFE return TRUE) in CloseHandle and the crash disappeared.

It was suggested that since CloseHandle is required, just to create an event or something simple so the handle will be through the calls.

If you are attempting to reproduce the crash.
Open Windows steam
Click on a game to view it's content.
Or Your Profile/Library/
Sometimes isn't crash straight away.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6345#note_79731

[Louis Lenders (＠xe)]

Hi Alistair,

Thanks for the patch fixing the regression. The regression also seems to cause chrome to crash I found.

@Julliard, if this patch is not approved by you, then please revert my PowerCreate patches before next release. Sorry about noise.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6345#note_79780