[PATCH 0/1] MR2997: wininet: Fix memory leaks on error paths in INTERNET_LoadProxySettings (scan-build).

[Alex Henrie (＠alexhenrie)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2997

[PATCH 1/1] wininet: Fix memory leaks on error paths in INTERNET_LoadProxySettings (scan-build).

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

---
 dlls/wininet/internet.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c
index a2d9f00ce6f..5af3aac71ea 100644
--- a/dlls/wininet/internet.c
+++ b/dlls/wininet/internet.c
@@ -637,6 +637,7 @@ static LONG INTERNET_LoadProxySettings( proxyinfo_t *lpwpi )
                 if (!(szProxy = malloc( len )))
                 {
                     RegCloseKey( key );
+                    FreeProxyInfo( lpwpi );
                     return ERROR_OUTOFMEMORY;
                 }
                 RegQueryValueExW( key, L"ProxyOverride", NULL, &type, (BYTE*)szProxy, &len );
@@ -661,6 +662,7 @@ static LONG INTERNET_LoadProxySettings( proxyinfo_t *lpwpi )
             if (!(envproxyW = malloc( wcslen(envproxy) * sizeof(WCHAR) )))
             {
                 RegCloseKey( key );
+                FreeProxyInfo( lpwpi );
                 return ERROR_OUTOFMEMORY;
             }
             lstrcpyW( envproxyW, envproxy );
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2997

[PATCH 1/1] wininet: Fix memory leaks on error paths in INTERNET_LoadProxySettings (scan-build).

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=133526

Your paranoid android.


=== debian11 (32 bit report) ===

user32:
msg.c:6897: Test failed: SetFocus(hwnd) on a button: 4: the msg 0x0007 was expected, but got msg 0x0005 instead
msg.c:6897: Test failed: SetFocus(hwnd) on a button: 5: the msg 0x0135 was expected, but got msg 0x030f instead
msg.c:6897: Test failed: SetFocus(hwnd) on a button: 6: the msg 0x0111 was expected, but got msg 0x001c instead
msg.c:6897: Test failed: SetFocus(hwnd) on a button: 7: the msg 0x8000 was expected, but got msg 0x0086 instead
msg.c:6897: Test failed: SetFocus(hwnd) on a button: 8: the msg sequence is not complete: expected 0000 - actual 0006

[PATCH 0/1] MR2997: wininet: Fix memory leaks on error paths in INTERNET_LoadProxySettings (scan-build). - approved

[Jacek Caban (＠jacek)]

This merge request was approved by Jacek Caban.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2997