[PATCH 0/1] MR4785: windows.media.speech/tests: Remove obsolete workarounds.
These got obsolete with eaca0f44be41e0543dd2f3909012cdcf041328a7. Signed-off-by: Bernhard Kölbl <bkoelbl(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4785
From: Bernhard Kölbl <bkoelbl(a)codeweavers.com> These got obsolete with eaca0f44be41e0543dd2f3909012cdcf041328a7. Signed-off-by: Bernhard Kölbl <bkoelbl(a)codeweavers.com> --- dlls/windows.media.speech/tests/speech.c | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/dlls/windows.media.speech/tests/speech.c b/dlls/windows.media.speech/tests/speech.c index feeeda58be4..ea1487d379c 100644 --- a/dlls/windows.media.speech/tests/speech.c +++ b/dlls/windows.media.speech/tests/speech.c @@ -1472,17 +1472,6 @@ static void test_SpeechRecognitionListConstraint(void) hr = ISpeechRecognitionListConstraintFactory_CreateWithTag(listconstraint_factory, NULL, NULL, &listconstraint); ok(hr == E_POINTER, "ISpeechRecognitionListConstraintFactory_Create failed, hr %#lx.\n", hr); - /* - * The create functions break on Win10 <= 1709 x32 with the given iterator. - * Seems like a Windows bug, but if you see an issue in the test's code, please FIXME. - * Skipping these tests. - */ - if (broken((is_win10_1507 || is_win10_1709) && (sizeof(void*) == 4))) - { - win_skip("SpeechRecognitionListConstraint object creation broken on Win10 <= 1709 x32!\n"); - goto skip_create; - } - iterator_hstring_create_static(&iterator_hstring, commands, ARRAY_SIZE(commands)); iterable_hstring_create_static(&iterable_hstring, &iterator_hstring); @@ -1553,7 +1542,6 @@ skip_tests: ref = ISpeechRecognitionListConstraint_Release(listconstraint); ok(ref == 0, "Got unexpected ref %lu.\n", ref); -skip_create: ref = ISpeechRecognitionListConstraintFactory_Release(listconstraint_factory); ok(ref == 2, "Got unexpected ref %lu.\n", ref); @@ -1628,17 +1616,6 @@ static void test_Recognition(void) ok(hr == S_OK, "WindowsCreateString failed, hr %#lx.\n", hr); } - /* - * The create functions break on Win10 <= 1709 x32 with the given iterator. - * Seems like a Windows bug, but if you see an issue in the test's code, please FIXME. - * Skipping these tests. - */ - if (broken((is_win10_1507 || is_win10_1709) && (sizeof(void*) == 4))) - { - win_skip("SpeechRecognitionListConstraint object creation broken on Win10 <= 1709 x32!\n"); - goto done; - } - hr = WindowsCreateString(recognizer_name, wcslen(recognizer_name), &hstr); ok(hr == S_OK, "WindowsCreateString failed, hr %#lx.\n", hr); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4785
participants (1)
-
Bernhard Kölbl