[PATCH 0/1] MR5545: Fix a typo

[Ruslan Garipov (＠ruslangaripov)]

Trivial patch fixing a typo in a comment.  Please, review.

No functional changes intended.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5545

[PATCH 1/1] Fix a typo

[Ruslan Garipov]

From: Ruslan Garipov <ruslanngaripov(a)gmail.com>

No functional changes intended.

Signed-off-by: Ruslan Garipov <ruslanngaripov(a)gmail.com>
---
 dlls/ntdll/unix/server.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/ntdll/unix/server.c b/dlls/ntdll/unix/server.c
index 438c16518bd..0d5e4a4b61c 100644
--- a/dlls/ntdll/unix/server.c
+++ b/dlls/ntdll/unix/server.c
@@ -1079,7 +1079,7 @@ static int remove_fd_from_cache( HANDLE handle )
 /***********************************************************************
  *           server_get_unix_fd
  *
- * The returned unix_fd should be closed iff needs_close is non-zero.
+ * The returned unix_fd should be closed if needs_close is non-zero.
  */
 int server_get_unix_fd( HANDLE handle, unsigned int wanted_access, int *unix_fd,
                         int *needs_close, enum server_fd_type *type, unsigned int *options )
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5545

[PATCH 1/1] Fix a typo

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=145235

Your paranoid android.


=== debian11b (64 bit WoW report) ===

quartz:
dsoundrender: Timeout

[Elizabeth Figura (＠zfigura)]

I don't think this is a typo. "iff" is shorthand for "if and only if".

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5545#note_68965

[Ruslan Garipov (＠ruslangaripov)]

On Fri Apr 26 20:55:51 2024 +0000, Elizabeth Figura wrote:
> I don't think this is a typo. "iff" is shorthand for "if and only if".
> Didn't know that, sorry.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5545#note_68966

[PATCH 0/1] MR5545: Fix a typo - closed

[Ruslan Garipov (＠ruslangaripov)]

This merge request was closed by Ruslan Garipov.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5545