[PATCH 0/1] MR2979: jscript: Fix memory leak on error path in String_replace (scan-build).

[Alex Henrie (＠alexhenrie)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2979

[PATCH 1/1] jscript: Fix memory leak on error path in String_replace (scan-build).

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

---
 dlls/jscript/string.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/jscript/string.c b/dlls/jscript/string.c
index 14bcfbdaaf3..f7d02f1582a 100644
--- a/dlls/jscript/string.c
+++ b/dlls/jscript/string.c
@@ -926,8 +926,10 @@ static HRESULT String_replace(script_ctx_t *ctx, jsval_t vthis, WORD flags, unsi
         jsstr_t *ret_str;
 
         ret_str = jsstr_alloc_len(ret.buf, ret.len);
-        if(!ret_str)
+        if(!ret_str) {
+            free(ret.buf);
             return E_OUTOFMEMORY;
+        }
 
         TRACE("= %s\n", debugstr_jsstr(ret_str));
         *r = jsval_string(ret_str);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2979

[PATCH 0/1] MR2979: jscript: Fix memory leak on error path in String_replace (scan-build). - approved

[Jacek Caban (＠jacek)]

This merge request was approved by Jacek Caban.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2979