Re: [PATCH v43 0/1] MR7843: cmd: Implement tab completion for command line entry.

[eric pouech (＠epo)]

eric pouech (@epo) commented about programs/cmd/wcmdmain.c:
> +            clear_console_characters(hOutput, maxLen - len, lastConsoleInfo.dwSize.X); /* width at time of last console update */
> +        }
> +        set_cursor_visible(hOutput, TRUE);
> +
> +        /* Remember current dimensions in case user resizes console window. */
> +        GetConsoleScreenBufferInfo(hOutput, &lastConsoleInfo);
> +
> +        inputControl.nLength = sizeof(inputControl);
> +        inputControl.nInitialChars = len;
> +        inputControl.dwCtrlWakeupMask = (1 << '\t');
> +        inputControl.dwControlKeyState = 0;
> +
> +        /* Allow room for NULL terminator. inputBufferLength is at least 1 due to check above. */
> +        ret = ReadConsoleW(hInput, inputBuffer, inputBufferLength - 1, numRead, &inputControl);
> +
> +        if (ret) {
> I'd rather do `if (!ret) break;` so that you gain an indentation level afterwards

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103748