[PATCH 0/1] MR9675: winemac: Avoid taking the window lock when creating client surface.

[Rémi Bernon]

It's not even necessary anymore, and macdrv_create_view blocks on
the main thread, which sometimes seems to trigger a deadlock.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9675

[PATCH 1/1] winemac: Avoid taking the window lock when creating client surface.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

It's not even necessary anymore, and macdrv_create_view blocks on
the main thread, which sometimes seems to trigger a deadlock.
---
 dlls/winemac.drv/window.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c
index acb90420bcd..9420e17f810 100644
--- a/dlls/winemac.drv/window.c
+++ b/dlls/winemac.drv/window.c
@@ -1149,17 +1149,14 @@ struct macdrv_client_surface *macdrv_client_surface_create(HWND hwnd)
 {
     HWND toplevel = NtUserGetAncestor(hwnd, GA_ROOT);
     struct macdrv_client_surface *surface;
-    struct macdrv_win_data *data;
     RECT rect;
 
     NtUserGetClientRect(hwnd, &rect, NtUserGetWinMonitorDpi(hwnd, MDT_RAW_DPI));
     NtUserMapWindowPoints(hwnd, toplevel, (POINT *)&rect, 2, NtUserGetWinMonitorDpi(toplevel, MDT_RAW_DPI));
 
-    if (!(data = get_win_data(toplevel))) return FALSE;
     surface = client_surface_create(sizeof(*surface), &macdrv_client_surface_funcs, hwnd);
     surface->cocoa_view = macdrv_create_view(cgrect_from_rect(rect));
     macdrv_set_view_hidden(surface->cocoa_view, TRUE);
-    release_win_data(data);
 
     if (surface)
     {
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9675