[PATCH 0/2] MR2099: tests: Actually test the return value of some function calls
From: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/mshtml/tests/events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mshtml/tests/events.c b/dlls/mshtml/tests/events.c index ecc3bfb3bc1..a410b464756 100644 --- a/dlls/mshtml/tests/events.c +++ b/dlls/mshtml/tests/events.c @@ -3170,7 +3170,7 @@ static void test_doc_obj(IHTMLDocument2 *doc) ok(!!event_target, "event_target = NULL\n"); bstr = SysAllocString(L"click"); - IEventTarget_addEventListener(event_target, bstr, (IDispatch*)&docobj_onclick_obj, TRUE); + hres = IEventTarget_addEventListener(event_target, bstr, (IDispatch*)&docobj_onclick_obj, TRUE); ok(hres == S_OK, "addEventListener failed: %08lx\n", hres); SysFreeString(bstr); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/2099
From: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/d3d11/tests/d3d11.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c index de548672c2b..a13d350c582 100644 --- a/dlls/d3d11/tests/d3d11.c +++ b/dlls/d3d11/tests/d3d11.c @@ -21839,7 +21839,7 @@ static void test_stencil_separate(void) rs_desc.ScissorEnable = FALSE; rs_desc.MultisampleEnable = FALSE; rs_desc.AntialiasedLineEnable = FALSE; - ID3D11Device_CreateRasterizerState(device, &rs_desc, &rs); + hr = ID3D11Device_CreateRasterizerState(device, &rs_desc, &rs); ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr); ID3D11DeviceContext_ClearRenderTargetView(context, test_context.backbuffer_rtv, red); @@ -21859,7 +21859,7 @@ static void test_stencil_separate(void) ID3D11RasterizerState_Release(rs); rs_desc.FrontCounterClockwise = TRUE; - ID3D11Device_CreateRasterizerState(device, &rs_desc, &rs); + hr = ID3D11Device_CreateRasterizerState(device, &rs_desc, &rs); ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr); ID3D11DeviceContext_RSSetState(context, rs); @@ -28408,7 +28408,7 @@ static void test_depth_bias(void) for (k = 0; k < ARRAY_SIZE(bias_clamp_tests); ++k) { rasterizer_desc.DepthBiasClamp = bias_clamp_tests[k]; - ID3D11Device_CreateRasterizerState(device, &rasterizer_desc, &rs); + hr = ID3D11Device_CreateRasterizerState(device, &rasterizer_desc, &rs); ok(hr == S_OK, "Format %#x, quad %u, bias %u, clamp %u: Got unexpected hr %#lx.\n", format, i, j, k, hr); ID3D11DeviceContext_RSSetState(context, rs); @@ -28492,7 +28492,7 @@ static void test_depth_bias(void) { BOOL all_match = TRUE; rasterizer_desc.DepthBiasClamp = bias_clamp_tests[k]; - ID3D11Device_CreateRasterizerState(device, &rasterizer_desc, &rs); + hr = ID3D11Device_CreateRasterizerState(device, &rasterizer_desc, &rs); ok(hr == S_OK, "Format %#x, slope %u, bias %u, clamp %u: Got unexpected hr %#lx.\n", format, i, j, k, hr); ID3D11DeviceContext_RSSetState(context, rs); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/2099
Can't run the d3d11 test as it crashes for me, similar to those on https://test.winehq.org/data/tests/d3d11:d3d11.html -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2099#note_22875
This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2099
This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2099
This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2099
participants (5)
-
Jacek Caban (＠jacek) -
Jan Sikorski (＠jsikorski)
-
Michael Stefaniuc
-
Michael Stefaniuc (＠mstefani)
-
Zebediah Figura (＠zfigura)