[PATCH 0/1] MR1112: comctl32/tests: Use a toolbar with TBSTYLE_FLAT in toolbar visual tests.
Fix a test failure when theming is off. A toolbar without TBSTYLE_FLAT will fill its checked button background rectangle when theming is inactive, overwriting the checked pattern required for the test. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1112
From: Zhiyi Zhang <zzhang(a)codeweavers.com> Fix a test failure when theming is off. A toolbar without TBSTYLE_FLAT will fill its checked button background rectangle when theming is inactive, overwriting the checked pattern required for the test. --- dlls/comctl32/tests/toolbar.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/comctl32/tests/toolbar.c b/dlls/comctl32/tests/toolbar.c index f66094a0b3a..7c886e1f88f 100644 --- a/dlls/comctl32/tests/toolbar.c +++ b/dlls/comctl32/tests/toolbar.c @@ -2646,7 +2646,8 @@ static void test_visual(void) RECT rect; BOOL ret; - toolbar = CreateWindowA(TOOLBARCLASSNAMEA, "", WS_CHILD | WS_VISIBLE, 0, 0, 50, 50, hMainWnd, 0, 0, NULL); + toolbar = CreateWindowA(TOOLBARCLASSNAMEA, "", WS_CHILD | WS_VISIBLE | TBSTYLE_FLAT, 0, 0, 50, + 50, hMainWnd, 0, 0, NULL); ok(!!toolbar, "Failed to create a toolbar window.\n"); /* Test that the comctl32 55AA pattern brush is not used to draw checked background when theming is on */ -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/1112
This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1112
participants (3)
-
Nikolay Sivov (@nsivov) -
Zhiyi Zhang -
Zhiyi Zhang (@zhiyi)