Re: [PATCH v10 0/1] MR6453: emfdc: avoid memory leaks in get_bitmap_info
10 Sep
2024
10 Sep
'24
12:08 p.m.
Jacek Caban (@jacek) commented about dlls/gdi32/emfdc.c:
if (!SelectObject( blit_dc, blit_bitmap )) goto err; if (!BitBlt( blit_dc, 0, 0, bmp.bmWidth, bmp.bmHeight, *hdc, 0, 0, SRCCOPY )) goto err; + + *hdc = blit_dc; + *bitmap = blit_bitmap; } if (!GetDIBits( blit_dc, blit_bitmap, 0, INT_MAX, NULL, info, DIB_RGB_COLORS )) goto err;
We'd still leak if `GetDIBits` fails. We could move setting it after `GetDIBits` call, but it's maybe easier to just duplicate `GetDIBits` call inside if-else statement. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6453#note_81769
541
Age (days ago)
541
Last active (days ago)
0 comments
1 participants
participants (1)
-
Jacek Caban (@jacek)