[PATCH 0/6] MR986: kernel32/tests: Mark tests failing randomly on Windows as flaky.
From: Francois Gouget <fgouget(a)codeweavers.com> Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53145 --- dlls/kernel32/tests/loader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/kernel32/tests/loader.c b/dlls/kernel32/tests/loader.c index 365f4465fc7..1dfc2dd4b20 100644 --- a/dlls/kernel32/tests/loader.c +++ b/dlls/kernel32/tests/loader.c @@ -717,6 +717,7 @@ static NTSTATUS map_image_section( const IMAGE_NT_HEADERS *nt_header, const IMAG } else { + flaky ok( ldr_status == expect_status || broken(il_only && !expect_status && ldr_status == STATUS_INVALID_IMAGE_FORMAT) || broken(nt_header->Signature == IMAGE_OS2_SIGNATURE && ldr_status == STATUS_INVALID_IMAGE_NE_FORMAT), -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/986
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=124676 Your paranoid android. === w1064 (32 bit report) === kernel32: loader.c:721: Test marked flaky: 1225: wrong status c0000130/c000007b loader.c:721: Test marked flaky: 1230: wrong status c0000130/c000007b loader.c:721: Test marked flaky: 1235: wrong status c0000130/c000007b loader.c:721: Test marked flaky: 1240: wrong status c0000130/c000007b loader.c:721: Test marked flaky: 1245: wrong status c0000130/c000007b loader.c:721: Test marked flaky: 1261: wrong status c0000130/0 loader.c:721: Test marked flaky: 1265: wrong status c0000130/0 loader.c:721: Test marked flaky: 1270: wrong status c0000130/0 loader.c:721: Test marked flaky: 1274: wrong status c0000130/0 loader.c:721: Test marked flaky: 1278: wrong status c0000130/0 loader.c:721: Test marked flaky: 1317: wrong status c0000130/c000007b loader.c:721: Test marked flaky: 1326: wrong status c0000130/c000007b loader.c:721: Test marked flaky: 1331: wrong status c0000130/0 loader.c:721: Test marked flaky: 1338: wrong status c0000130/0 loader.c:721: Test marked flaky: 1345: wrong status c0000130/0 loader.c:721: Test marked flaky: 1353: wrong status c0000130/0 loader.c:721: Test marked flaky: 1360: wrong status c0000130/0 === w1064_2qxl (64 bit report) === kernel32: loader.c:721: Test marked flaky: 1220: wrong status c000011b/c0000130 loader.c:721: Test marked flaky: 1225: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1230: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1235: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1240: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1245: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1261: wrong status c000011b/0 loader.c:721: Test marked flaky: 1265: wrong status c000011b/0 loader.c:721: Test marked flaky: 1270: wrong status c000011b/0 Report validation errors: kernel32:loader has unaccounted for failure messages kernel32:loader returned success despite having failures === w10pro64 (64 bit report) === kernel32: loader.c:721: Test marked flaky: 1193: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c0000131 loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c0000130 loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1215: wrong status c000012f/c0000130 loader.c:721: Test marked flaky: 1220: wrong status c000012f/c0000130 Report validation errors: kernel32:loader has unaccounted for failure messages kernel32:loader returned success despite having failures === w10pro64_en_AE_u8 (64 bit report) === kernel32: loader.c:721: Test marked flaky: 1220: wrong status c000011b/c0000130 loader.c:721: Test marked flaky: 1225: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1230: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1235: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1240: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1245: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1261: wrong status c000011b/0 loader.c:721: Test marked flaky: 1265: wrong status c000011b/0 loader.c:721: Test marked flaky: 1270: wrong status c000011b/0 loader.c:721: Test marked flaky: 1274: wrong status c000011b/0 loader.c:721: Test marked flaky: 1278: wrong status c000011b/0 loader.c:721: Test marked flaky: 1432: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1440: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1445: wrong status c000011b/0 loader.c:721: Test marked flaky: 1451: wrong status c000011b/0 loader.c:721: Test marked flaky: 1457: wrong status c000011b/0 loader.c:721: Test marked flaky: 1464: wrong status c000011b/0 loader.c:721: Test marked flaky: 1470: wrong status c000011b/0 loader.c:721: Test marked flaky: 1479: wrong status c000011b/0 loader.c:721: Test marked flaky: 1483: wrong status c000011b/0 loader.c:721: Test marked flaky: 1487: wrong status c000011b/0 loader.c:721: Test marked flaky: 1491: wrong status c000011b/0 loader.c:721: Test marked flaky: 1495: wrong status c000011b/0 === w10pro64_ar (64 bit report) === kernel32: loader.c:721: Test marked flaky: 1220: wrong status c000011b/c0000130 loader.c:721: Test marked flaky: 1225: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1230: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1235: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1240: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1245: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1261: wrong status c000011b/0 loader.c:721: Test marked flaky: 1265: wrong status c000011b/0 loader.c:721: Test marked flaky: 1270: wrong status c000011b/0 loader.c:721: Test marked flaky: 1274: wrong status c000011b/0 loader.c:721: Test marked flaky: 1278: wrong status c000011b/0 loader.c:721: Test marked flaky: 1432: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1440: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1445: wrong status c000011b/0 loader.c:721: Test marked flaky: 1451: wrong status c000011b/0 loader.c:721: Test marked flaky: 1457: wrong status c000011b/0 loader.c:721: Test marked flaky: 1464: wrong status c000011b/0 loader.c:721: Test marked flaky: 1470: wrong status c000011b/0 loader.c:721: Test marked flaky: 1479: wrong status c000011b/0 loader.c:721: Test marked flaky: 1483: wrong status c000011b/0 loader.c:721: Test marked flaky: 1487: wrong status c000011b/0 loader.c:721: Test marked flaky: 1491: wrong status c000011b/0 loader.c:721: Test marked flaky: 1495: wrong status c000011b/0 === w10pro64_ja (64 bit report) === kernel32: loader.c:721: Test marked flaky: 1220: wrong status c000011b/c0000130 loader.c:721: Test marked flaky: 1225: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1230: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1235: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1240: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1245: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1261: wrong status c000011b/0 loader.c:721: Test marked flaky: 1265: wrong status c000011b/0 loader.c:721: Test marked flaky: 1270: wrong status c000011b/0 loader.c:721: Test marked flaky: 1274: wrong status c000011b/0 loader.c:721: Test marked flaky: 1278: wrong status c000011b/0 loader.c:721: Test marked flaky: 1432: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1440: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1445: wrong status c000011b/0 loader.c:721: Test marked flaky: 1451: wrong status c000011b/0 loader.c:721: Test marked flaky: 1457: wrong status c000011b/0 loader.c:721: Test marked flaky: 1464: wrong status c000011b/0 loader.c:721: Test marked flaky: 1470: wrong status c000011b/0 loader.c:721: Test marked flaky: 1479: wrong status c000011b/0 loader.c:721: Test marked flaky: 1483: wrong status c000011b/0 loader.c:721: Test marked flaky: 1487: wrong status c000011b/0 loader.c:721: Test marked flaky: 1491: wrong status c000011b/0 loader.c:721: Test marked flaky: 1495: wrong status c000011b/0
From: Francois Gouget <fgouget(a)codeweavers.com> Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53519 --- dlls/kernel32/tests/comm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/kernel32/tests/comm.c b/dlls/kernel32/tests/comm.c index 415af5aca09..d4cc81a64f3 100644 --- a/dlls/kernel32/tests/comm.c +++ b/dlls/kernel32/tests/comm.c @@ -1583,6 +1583,7 @@ static void test_AbortWaitCts(void) evtmask, 0); ok(GetCommModemStatus(hcom, &evtmask), "GetCommModemStatus failed\n"); diff = after1 - before; + flaky ok ((diff > (TIMEOUT>>1) -TIMEDELTA) && (diff < (TIMEOUT>>1) + TIMEDELTA), "Unexpected time %ld, expected around %d\n", diff, TIMEOUT>>1); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/986
From: Francois Gouget <fgouget(a)codeweavers.com> Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=47873 --- dlls/kernel32/tests/comm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/dlls/kernel32/tests/comm.c b/dlls/kernel32/tests/comm.c index d4cc81a64f3..ec63d4ae553 100644 --- a/dlls/kernel32/tests/comm.c +++ b/dlls/kernel32/tests/comm.c @@ -856,6 +856,7 @@ static void test_waittxempty(void) after = GetTickCount(); ok(after - before < 30, "WaitCommEvent should have returned immediately, took %ld ms\n", after - before); res = WaitForSingleObject(ovl_wait.hEvent, 1500); + flaky ok(res == WAIT_OBJECT_0, "WaitCommEvent failed with a timeout\n"); if (res == WAIT_OBJECT_0) { @@ -877,12 +878,15 @@ static void test_waittxempty(void) res = FALSE; } after = GetTickCount(); + flaky ok(res, "WaitCommEvent error %ld\n", GetLastError()); + flaky ok(evtmask & EV_TXEMPTY, "WaitCommEvent: expected EV_TXEMPTY, got %#lx\n", evtmask); CloseHandle(ovl_wait.hEvent); timediff = after - before; trace("WaitCommEvent for EV_TXEMPTY took %ld ms (timeout 1500)\n", timediff); + flaky ok(timediff < 1200, "WaitCommEvent used %ld ms for waiting\n", timediff); res = WaitForSingleObject(ovl_write.hEvent, 0); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/986
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=124678 Your paranoid android. === w7u_adm (32 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1514 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w864 (32 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1500 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w1064v1809 (32 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1500 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w1064 (32 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1500 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w1064_tsign (32 bit report) === kernel32: comm.c:1591: Test marked flaky: Unexpected time 328, expected around 500 Report validation errors: kernel32:comm returned success despite having failures === w864 (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1516 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w1064v1809 (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1500 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w1064 (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1500 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w1064_2qxl (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1500 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w1064_adm (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1515 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w1064_tsign (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1516 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w10pro64_en_AE_u8 (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1516 ms for waiting Report validation errors: kernel32:comm returned success despite having failures === w10pro64_ar (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1516 ms for waiting Report validation errors: kernel32:comm returned success despite having failures === w10pro64_ja (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1500 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w10pro64_zh_CN (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1515 ms for waiting Report validation errors: kernel32:comm returned success despite having failures
From: Francois Gouget <fgouget(a)codeweavers.com> Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53144 --- dlls/kernel32/tests/debugger.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/kernel32/tests/debugger.c b/dlls/kernel32/tests/debugger.c index abd59c93f88..4e9fe88ede1 100644 --- a/dlls/kernel32/tests/debugger.c +++ b/dlls/kernel32/tests/debugger.c @@ -2119,6 +2119,7 @@ static void test_kill_on_exit(const char *argv0) TerminateThread( thread, 0 ); status = pNtSetInformationDebugObject( debug, DebugObjectKillProcessOnExitInformation, &val, sizeof(val), NULL ); + flaky ok( status == STATUS_SUCCESS, "NtSetInformationDebugObject failed %lx\n", status ); WaitForSingleObject( pi.hProcess, 300 ); GetExitCodeProcess( pi.hProcess, &exit_code ); @@ -2141,6 +2142,7 @@ static void test_kill_on_exit(const char *argv0) TerminateThread( thread, 0 ); status = pNtSetInformationDebugObject( debug, DebugObjectKillProcessOnExitInformation, &val, sizeof(val), NULL ); + flaky ok( status == STATUS_SUCCESS, "NtSetInformationDebugObject failed %lx\n", status ); CloseHandle( debug ); CloseHandle( thread ); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/986
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=124679 Your paranoid android. === w7u_2qxl (32 bit report) === kernel32: debugger.c:1027: Test failed: ole32.dll was not reported === w7u_adm (32 bit report) === kernel32: debugger.c:1027: Test failed: ole32.dll was not reported debugger.c:2123: Test marked flaky: NtSetInformationDebugObject failed c0000008 === w7u_el (32 bit report) === kernel32: debugger.c:1027: Test failed: ole32.dll was not reported
From: Francois Gouget <fgouget(a)codeweavers.com> Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53143 --- dlls/kernel32/tests/debugger.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/kernel32/tests/debugger.c b/dlls/kernel32/tests/debugger.c index 4e9fe88ede1..f038514506e 100644 --- a/dlls/kernel32/tests/debugger.c +++ b/dlls/kernel32/tests/debugger.c @@ -1757,6 +1757,7 @@ static void test_debugger(const char *argv0) ctx.ev.u.Exception.ExceptionRecord.ExceptionCode); ok(ctx.ev.u.Exception.ExceptionRecord.ExceptionAddress == thread_proc + 1, "ExceptionAddress = %p\n", ctx.ev.u.Exception.ExceptionRecord.ExceptionAddress); + flaky ok(get_ip(&prev_thread->ctx) == thread_proc + 2 || broken(get_ip(&prev_thread->ctx) == thread_proc), /* sometimes observed on win10 */ "unexpected instruction pointer %p\n", get_ip(&prev_thread->ctx)); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/986
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=124680 Your paranoid android. === w7u_2qxl (32 bit report) === kernel32: debugger.c:1027: Test failed: ole32.dll was not reported === w7u_adm (32 bit report) === kernel32: debugger.c:1027: Test failed: ole32.dll was not reported debugger.c:2147: Test marked flaky: NtSetInformationDebugObject failed c0000008 === w7u_el (32 bit report) === kernel32: debugger.c:1027: Test failed: ole32.dll was not reported debugger.c:2147: Test marked flaky: NtSetInformationDebugObject failed c0000008 === w10pro64 (32 bit report) === kernel32: debugger.c:447: Test failed: unexpected thread debugger.c:450: Test failed: dwDebugEventCode = 2 debugger.c:451: Test failed: ExceptionCode = 584 debugger.c:453: Test failed: ExceptionAddress != DbgBreakPoint debugger.c:466: Test failed: dwDebugEventCode = 1 === w10pro64_ar (64 bit report) === kernel32: debugger.c:1761: Test marked flaky: unexpected instruction pointer 00007FFC5224CE54 Report validation errors: kernel32:debugger returned success despite having failures
From: Francois Gouget <fgouget(a)codeweavers.com> Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53456 --- dlls/kernel32/tests/debugger.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/kernel32/tests/debugger.c b/dlls/kernel32/tests/debugger.c index f038514506e..a366313ac2a 100644 --- a/dlls/kernel32/tests/debugger.c +++ b/dlls/kernel32/tests/debugger.c @@ -152,6 +152,7 @@ static int load_blackbox(const char* logfile, void* blackbox, int size) hFile=CreateFileA(logfile, GENERIC_READ, 0, NULL, OPEN_EXISTING, 0, 0); if (hFile == INVALID_HANDLE_VALUE) { + flaky ok(0, "unable to open '%s'\n", logfile); return 0; } @@ -673,6 +674,7 @@ static void crash_and_debug(HKEY hkey, const char* argv0, const char* dbgtasks) ok(load_blackbox(dbglog, &dbg_blackbox, sizeof(dbg_blackbox)), "failed to open: %s\n", dbglog); ok(dbg_blackbox.argc == 6, "wrong debugger argument count: %d\n", dbg_blackbox.argc); + flaky ok(dbg_blackbox.pid == info.dwProcessId, "the child and debugged pids don't match: %ld != %ld\n", info.dwProcessId, dbg_blackbox.pid); ok(dbg_blackbox.debug_rc, "debugger: SetEvent(debug_event) failed err=%ld\n", dbg_blackbox.debug_err); ok(dbg_blackbox.attach_rc, "DebugActiveProcess(%ld) failed err=%ld\n", dbg_blackbox.pid, dbg_blackbox.attach_err); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/986
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=124681 Your paranoid android. === w7u_2qxl (32 bit report) === kernel32: debugger.c:1029: Test failed: ole32.dll was not reported === w7u_adm (32 bit report) === kernel32: debugger.c:1029: Test failed: ole32.dll was not reported === w7u_el (32 bit report) === kernel32: debugger.c:1029: Test failed: ole32.dll was not reported === w1064 (32 bit report) === kernel32: debugger.c:1763: Test marked flaky: unexpected instruction pointer 77312A0C debugger.c:2130: Test failed: exit code = 00000000 === w1064_tsign (32 bit report) === kernel32: debugger.c:1763: Test marked flaky: unexpected instruction pointer 777C2A0C Report validation errors: kernel32:debugger has unaccounted for failure messages kernel32:debugger returned success despite having failures === w1064_2qxl (64 bit report) === kernel32: debugger.c:2126: Test marked flaky: NtSetInformationDebugObject failed c0000008 debugger.c:2130: Test failed: exit code = 00000000
On Sat Oct 1 13:01:37 2022 +0000, **** wrote:
Marvin replied on the mailing list: ``` Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=124678 Your paranoid android. === w7u_adm (32 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1514 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w864 (32 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1500 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w1064v1809 (32 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1500 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w1064 (32 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1500 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w1064_tsign (32 bit report) === kernel32: comm.c:1591: Test marked flaky: Unexpected time 328, expected around 500 Report validation errors: kernel32:comm returned success despite having failures === w864 (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1516 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w1064v1809 (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1500 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w1064 (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1500 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w1064_2qxl (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1500 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w1064_adm (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1515 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w1064_tsign (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1516 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w10pro64_en_AE_u8 (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1516 ms for waiting Report validation errors: kernel32:comm returned success despite having failures === w10pro64_ar (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1516 ms for waiting Report validation errors: kernel32:comm returned success despite having failures === w10pro64_ja (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1500 ms for waiting Report validation errors: kernel32:comm has unaccounted for failure messages kernel32:comm returned success despite having failures === w10pro64_zh_CN (64 bit report) === kernel32: comm.c:860: Test marked flaky: WaitCommEvent failed with a timeout comm.c:882: Test marked flaky: WaitCommEvent error 0 comm.c:884: Test marked flaky: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:890: Test marked flaky: WaitCommEvent used 1515 ms for waiting Report validation errors: kernel32:comm returned success despite having failures ``` All flaky so it's okay. The accounting issues are because the flaky are no longer counted as failures but the TestBot was now updated.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/986#note_9931
On Sat Oct 1 12:45:43 2022 +0000, **** wrote:
Marvin replied on the mailing list: ``` Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=124676 Your paranoid android. === w1064 (32 bit report) === kernel32: loader.c:721: Test marked flaky: 1225: wrong status c0000130/c000007b loader.c:721: Test marked flaky: 1230: wrong status c0000130/c000007b loader.c:721: Test marked flaky: 1235: wrong status c0000130/c000007b loader.c:721: Test marked flaky: 1240: wrong status c0000130/c000007b loader.c:721: Test marked flaky: 1245: wrong status c0000130/c000007b loader.c:721: Test marked flaky: 1261: wrong status c0000130/0 loader.c:721: Test marked flaky: 1265: wrong status c0000130/0 loader.c:721: Test marked flaky: 1270: wrong status c0000130/0 loader.c:721: Test marked flaky: 1274: wrong status c0000130/0 loader.c:721: Test marked flaky: 1278: wrong status c0000130/0 loader.c:721: Test marked flaky: 1317: wrong status c0000130/c000007b loader.c:721: Test marked flaky: 1326: wrong status c0000130/c000007b loader.c:721: Test marked flaky: 1331: wrong status c0000130/0 loader.c:721: Test marked flaky: 1338: wrong status c0000130/0 loader.c:721: Test marked flaky: 1345: wrong status c0000130/0 loader.c:721: Test marked flaky: 1353: wrong status c0000130/0 loader.c:721: Test marked flaky: 1360: wrong status c0000130/0 === w1064_2qxl (64 bit report) === kernel32: loader.c:721: Test marked flaky: 1220: wrong status c000011b/c0000130 loader.c:721: Test marked flaky: 1225: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1230: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1235: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1240: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1245: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1261: wrong status c000011b/0 loader.c:721: Test marked flaky: 1265: wrong status c000011b/0 loader.c:721: Test marked flaky: 1270: wrong status c000011b/0 Report validation errors: kernel32:loader has unaccounted for failure messages kernel32:loader returned success despite having failures === w10pro64 (64 bit report) === kernel32: loader.c:721: Test marked flaky: 1193: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c0000131 loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c0000130 loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1198: wrong status c000012f/c000011b loader.c:721: Test marked flaky: 1215: wrong status c000012f/c0000130 loader.c:721: Test marked flaky: 1220: wrong status c000012f/c0000130 Report validation errors: kernel32:loader has unaccounted for failure messages kernel32:loader returned success despite having failures === w10pro64_en_AE_u8 (64 bit report) === kernel32: loader.c:721: Test marked flaky: 1220: wrong status c000011b/c0000130 loader.c:721: Test marked flaky: 1225: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1230: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1235: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1240: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1245: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1261: wrong status c000011b/0 loader.c:721: Test marked flaky: 1265: wrong status c000011b/0 loader.c:721: Test marked flaky: 1270: wrong status c000011b/0 loader.c:721: Test marked flaky: 1274: wrong status c000011b/0 loader.c:721: Test marked flaky: 1278: wrong status c000011b/0 loader.c:721: Test marked flaky: 1432: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1440: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1445: wrong status c000011b/0 loader.c:721: Test marked flaky: 1451: wrong status c000011b/0 loader.c:721: Test marked flaky: 1457: wrong status c000011b/0 loader.c:721: Test marked flaky: 1464: wrong status c000011b/0 loader.c:721: Test marked flaky: 1470: wrong status c000011b/0 loader.c:721: Test marked flaky: 1479: wrong status c000011b/0 loader.c:721: Test marked flaky: 1483: wrong status c000011b/0 loader.c:721: Test marked flaky: 1487: wrong status c000011b/0 loader.c:721: Test marked flaky: 1491: wrong status c000011b/0 loader.c:721: Test marked flaky: 1495: wrong status c000011b/0 === w10pro64_ar (64 bit report) === kernel32: loader.c:721: Test marked flaky: 1220: wrong status c000011b/c0000130 loader.c:721: Test marked flaky: 1225: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1230: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1235: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1240: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1245: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1261: wrong status c000011b/0 loader.c:721: Test marked flaky: 1265: wrong status c000011b/0 loader.c:721: Test marked flaky: 1270: wrong status c000011b/0 loader.c:721: Test marked flaky: 1274: wrong status c000011b/0 loader.c:721: Test marked flaky: 1278: wrong status c000011b/0 loader.c:721: Test marked flaky: 1432: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1440: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1445: wrong status c000011b/0 loader.c:721: Test marked flaky: 1451: wrong status c000011b/0 loader.c:721: Test marked flaky: 1457: wrong status c000011b/0 loader.c:721: Test marked flaky: 1464: wrong status c000011b/0 loader.c:721: Test marked flaky: 1470: wrong status c000011b/0 loader.c:721: Test marked flaky: 1479: wrong status c000011b/0 loader.c:721: Test marked flaky: 1483: wrong status c000011b/0 loader.c:721: Test marked flaky: 1487: wrong status c000011b/0 loader.c:721: Test marked flaky: 1491: wrong status c000011b/0 loader.c:721: Test marked flaky: 1495: wrong status c000011b/0 === w10pro64_ja (64 bit report) === kernel32: loader.c:721: Test marked flaky: 1220: wrong status c000011b/c0000130 loader.c:721: Test marked flaky: 1225: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1230: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1235: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1240: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1245: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1261: wrong status c000011b/0 loader.c:721: Test marked flaky: 1265: wrong status c000011b/0 loader.c:721: Test marked flaky: 1270: wrong status c000011b/0 loader.c:721: Test marked flaky: 1274: wrong status c000011b/0 loader.c:721: Test marked flaky: 1278: wrong status c000011b/0 loader.c:721: Test marked flaky: 1432: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1440: wrong status c000011b/c000007b loader.c:721: Test marked flaky: 1445: wrong status c000011b/0 loader.c:721: Test marked flaky: 1451: wrong status c000011b/0 loader.c:721: Test marked flaky: 1457: wrong status c000011b/0 loader.c:721: Test marked flaky: 1464: wrong status c000011b/0 loader.c:721: Test marked flaky: 1470: wrong status c000011b/0 loader.c:721: Test marked flaky: 1479: wrong status c000011b/0 loader.c:721: Test marked flaky: 1483: wrong status c000011b/0 loader.c:721: Test marked flaky: 1487: wrong status c000011b/0 loader.c:721: Test marked flaky: 1491: wrong status c000011b/0 loader.c:721: Test marked flaky: 1495: wrong status c000011b/0 ``` All flaky so it's okay. The accounting issues are because the flaky are no longer counted as failures but the TestBot was now updated.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/986#note_9932
This merge request was closed by Francois Gouget. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/986
participants (3)
-
Francois Gouget -
Francois Gouget (＠fgouget)
-
Marvin