[PATCH v2 0/1] MR1960: localspl: Avoid uninitialized variable in fill_builtin_form_info

[Gerald Pfeifer (＠gerald)]

As diagnosed by GCC 13:

    dlls/localspl/provider.c: In function ‘fill_builtin_form_info’:
    dlls/localspl/provider.c:3045:16: warning: ‘res_len’ may be used uninitialized [-Wmaybe-uninitialized]
     3045 |             if (res_len)
          |                ^

--
  v2: wrc: Avoid undefined behavior in the FreeBSD case
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1960

[PATCH v2 1/1] wrc: Avoid undefined behavior in the FreeBSD case

[Gerald Pfeifer]

From: Gerald Pfeifer <gerald(a)pfeifer.com>

init_argv0_dir has a special case for FreeBSD where one branch led to
an unitialized variable and undefined behavior. Initialize properly.
---
 tools/wrc/wrc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/wrc/wrc.c b/tools/wrc/wrc.c
index a1e59c3d2b3..9f231603ad4 100644
--- a/tools/wrc/wrc.c
+++ b/tools/wrc/wrc.c
@@ -305,6 +305,8 @@ static void init_argv0_dir( const char *argv0 )
     char *path = xmalloc( path_size );
     if (!sysctl( pathname, ARRAY_SIZE(pathname), path, &path_size, NULL, 0 ))
         dir = realpath( path, NULL );
+    else
+        dir = NULL;
     free( path );
 #else
     dir = realpath( argv0, NULL );
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1960

[PATCH v2 1/1] wrc: Avoid undefined behavior in the FreeBSD case

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=128414

Your paranoid android.


=== debian11 (build log) ===

error: patch failed: tools/wrc/wrc.c:305
Task: Patch failed to apply

=== debian11b (build log) ===

error: patch failed: tools/wrc/wrc.c:305
Task: Patch failed to apply