[PATCH 0/1] MR7398: winex11.drv: Don't add MWM_DECOR_BORDER to windows without a caption.

[Dmitry Timoshkov (＠dmitry)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7398

[PATCH 1/1] winex11.drv: Don't add MWM_DECOR_BORDER to windows without a caption.

[Dmitry Timoshkov]

From: Dmitry Timoshkov <dmitry(a)baikal.ru>

Also don't use MWM_DECOR_RESIZEH, window resizing is controlled by MWM_FUNC_RESIZE.

This patch fixes double caption observed under some WMs (Metacity, its
successor Mate, and XFCE), they always treat such windows as requesting
the caption decoration.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=42117
Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru>
---
 dlls/winex11.drv/window.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c
index 7ae1d8ef66a..60e62ad691f 100644
--- a/dlls/winex11.drv/window.c
+++ b/dlls/winex11.drv/window.c
@@ -446,9 +446,6 @@ static unsigned long get_mwm_decorations_for_style( DWORD style, DWORD ex_style
         if (style & WS_MINIMIZEBOX) ret |= MWM_DECOR_MINIMIZE;
         if (style & WS_MAXIMIZEBOX) ret |= MWM_DECOR_MAXIMIZE;
     }
-    if (ex_style & WS_EX_DLGMODALFRAME) ret |= MWM_DECOR_BORDER;
-    else if (style & WS_THICKFRAME) ret |= MWM_DECOR_BORDER | MWM_DECOR_RESIZEH;
-    else if ((style & (WS_DLGFRAME|WS_BORDER)) == WS_DLGFRAME) ret |= MWM_DECOR_BORDER;
     return ret;
 }
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7398

[Dmitry Timoshkov (＠dmitry)]

Can I get a review for this patch please?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7398#note_97653