[PATCH v2 0/1] MR1553: msvcrt: Fix errno set on dup from read-only file.

[xantares (＠xantares)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53950

--
  v2: msvcrt: Fix errno set on dup from read-only file.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1553

[PATCH v2 1/1] msvcrt: Fix errno set on dup from read-only file.

[Michel Zou]

From: Michel Zou <xantares09(a)hotmail.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53950
---
 dlls/msvcrt/file.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c
index 4a8c3510bd7..e72784eef41 100644
--- a/dlls/msvcrt/file.c
+++ b/dlls/msvcrt/file.c
@@ -1244,6 +1244,7 @@ int CDECL _dup2(int od, int nd)
 
   if (info_nd == &MSVCRT___badioinfo)
   {
+      *_errno() = EBADF;
       ret = -1;
   }
   else if (info_od->wxflag & WX_OPEN)
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1553

[PATCH v2 1/1] msvcrt: Fix errno set on dup from read-only file.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=126824

Your paranoid android.


=== debian11 (32 bit report) ===

winhttp:
notification.c:117: Test failed: 892: expected status 0x20000 got 0x200000
notification: Timeout

[xantares (＠xantares)]

On Sat Nov 26 19:59:19 2022 +0000, xantares wrote:
> changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/1553/diffs?diff_id=21230&start_sha=816d1de2b8023e5ca17a61869aa92e5845cfe912#ccef53ac65b20e4b2bd881d9a56c8b1e9475c779_1270_1270)
> like that?

I cannot test this, I only have 2 cpus :[

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1553#note_17577