Re: [PATCH v2 0/1] MR2029: dmime: Store WAVE data when Loading.

[Michael Stefaniuc (＠mstefani)]

Michael Stefaniuc (@mstefani) commented about dlls/dmime/segment.c:
> return CONTAINING_RECORD(iface, IDirectMusicSegment8Impl, dmobj.IPersistStream_iface);
>  }
>
> +static HRESULT parse_wave_form(IDirectMusicSegment8Impl *This, IStream *stream, const struct chunk_entry *riff)
> +{
> +    HRESULT hr;
> +    struct chunk_entry chunk = {.parent = riff};
> +
> +    TRACE("Parsing segment wave in %p: %s\n", stream, debugstr_chunk(riff));
> +
> +     while ((hr = stream_next_chunk(stream, &chunk)) == S_OK) {
> +        switch (chunk.id) {
> +            case mmioFOURCC('f','m','t',' '): {
> +                if (FAILED(hr = stream_chunk_get_data(stream, &chunk, &This->wave_format, chunk.size)))

Don't use the chunk.size there; use the sizeof the destination object, here sizeof(This->wave_format)

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2029#note_22347