Re: [PATCH v2 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.
12 Dec
2022
12 Dec
'22
10:28 a.m.
Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/preshader.c:
struct d3dx_parameters_store *parameters) { unsigned int *p; - unsigned int i, j, const_count; + unsigned int i, j, const_count, magic; double *dconst; HRESULT hr; unsigned int saved_word; unsigned int section_size;
+ magic = *ptr; + TRACE("Preshader version %#x.\n", *ptr & 0xffff);
It seems nice to also update the TRACE() to output the full 32-bit value. Additional nitpick: you can probably drop the "for 2 registers" part of the patch subject. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1682#note_19493
1104
Age (days ago)
1104
Last active (days ago)
0 comments
1 participants
participants (1)
-
Matteo Bruni (@Mystral)