[PATCH 0/3] MR4938: kernelbase,winevdm: Silence clang warnings.

[Jacek Caban (＠jacek)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4938

[PATCH 1/3] winevdm: Use char type for max length assignment.

[Jacek Caban]

From: Jacek Caban <jacek(a)codeweavers.com>

---
 programs/winevdm/winevdm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/programs/winevdm/winevdm.c b/programs/winevdm/winevdm.c
index 5b5f72db253..87c25f0d191 100644
--- a/programs/winevdm/winevdm.c
+++ b/programs/winevdm/winevdm.c
@@ -359,7 +359,7 @@ static char *build_command_line( char **argv )
         return NULL;
 
     p = cmd_line;
-    *p++ = (len < 256) ? len : 255;
+    *p++ = (len < 256) ? len : '\xff';
     for (arg = argv; *arg; arg++)
     {
         BOOL has_space,has_quote;
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/4938

[PATCH 2/3] kernelbase: Silence -Wsometimes-uninitialized clang warning.

[Jacek Caban]

From: Jacek Caban <jacek(a)codeweavers.com>

---
 dlls/kernelbase/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/kernelbase/debug.c b/dlls/kernelbase/debug.c
index edb6d321a46..43714c3be2e 100644
--- a/dlls/kernelbase/debug.c
+++ b/dlls/kernelbase/debug.c
@@ -1428,7 +1428,7 @@ DWORD WINAPI DECLSPEC_HOTPATCH GetModuleFileNameExW( HANDLE process, HMODULE mod
                                                      WCHAR *name, DWORD size )
 {
     BOOL wow64, found = FALSE;
-    DWORD len;
+    DWORD len = 0;
 
     if (!size) return 0;
 
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/4938

[PATCH 3/3] kernelbase: Silence -Warray-bounds clang warning.

[Jacek Caban]

From: Jacek Caban <jacek(a)codeweavers.com>

---
 dlls/kernelbase/file.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dlls/kernelbase/file.c b/dlls/kernelbase/file.c
index 42c47707582..e1ba92a6448 100644
--- a/dlls/kernelbase/file.c
+++ b/dlls/kernelbase/file.c
@@ -1488,9 +1488,10 @@ BOOL WINAPI DECLSPEC_HOTPATCH FindNextFileW( HANDLE handle, WIN32_FIND_DATAW *da
         /* don't return '.' and '..' in the root of the drive */
         if (info->is_root)
         {
-            if (dir_info->FileNameLength == sizeof(WCHAR) && dir_info->FileName[0] == '.') continue;
+            const WCHAR *file_name = dir_info->FileName;
+            if (dir_info->FileNameLength == sizeof(WCHAR) && file_name[0] == '.') continue;
             if (dir_info->FileNameLength == 2 * sizeof(WCHAR) &&
-                dir_info->FileName[0] == '.' && dir_info->FileName[1] == '.') continue;
+                file_name[0] == '.' && file_name[1] == '.') continue;
         }
 
         if (info->mask)
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4938