[PATCH v3 0/1] MR1934: conhost.exe: Initialize colop_map when creating an alternate screen buffer.

[eric pouech (＠epo)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54287

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com>

--
  v3: conhost.exe: Initialize colop_map when creating an alternate screen buffer.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1934

[PATCH v3 1/1] conhost.exe: Initialize colop_map when creating an alternate screen buffer.

[Eric Pouech]

From: Eric Pouech <eric.pouech(a)gmail.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54287

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com>
---
 programs/conhost/conhost.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/programs/conhost/conhost.c b/programs/conhost/conhost.c
index 769f998f404..fb20ed79555 100644
--- a/programs/conhost/conhost.c
+++ b/programs/conhost/conhost.c
@@ -96,6 +96,7 @@ static struct screen_buffer *create_screen_buffer( struct console *console, int
         screen_buffer->attr       = console->active->attr;
         screen_buffer->popup_attr = console->active->attr;
         screen_buffer->font       = console->active->font;
+        memcpy( screen_buffer->color_map, console->active->color_map, sizeof(console->active->color_map) );
 
         if (screen_buffer->font.face_len)
         {
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1934

[Hugh McMaster (＠hmc)]

Hi Eric,

Is there any evidence the color map table is copied from the active screen buffer? The official docs for CreateConsoleScreenBuffer don't mention it, but that's not to say it doesn't happen.

By the way, there's a typo in your commit title.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1934#note_20670

[eric pouech (＠epo)]

On Wed Jan 11 13:06:28 2023 +0000, Hugh McMaster wrote:
> Hi Eric,
> Is there any evidence the color map table is copied from the active
> screen buffer? The official docs for CreateConsoleScreenBuffer don't
> mention it, but that's not to say it doesn't happen.
> By the way, there's a typo in your commit title.
> no evidence I'm aware of, but since we're already inheriting all the other attributes (eg. font name) from the active screen buffer, I did the same.
> (will push an update for the typo, thx for looking into it)

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1934#note_20672