[PATCH 0/1] MR6162: ddraw: SecureZeroMemory did not reset to zero entire size obj, only size ptr

[Herman Semenov (＠GermanAizek)]

Maybe it's just typo who added this function.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6162

[PATCH 1/1] ddraw: SecureZeroMemory did not reset entire size obj, only size ptr

[Herman Semenov]

From: Herman Semenov <GermanAizek(a)yandex.ru>

---
 dlls/ddraw/clipper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/ddraw/clipper.c b/dlls/ddraw/clipper.c
index 3159a34cb5a..394fdec238b 100644
--- a/dlls/ddraw/clipper.c
+++ b/dlls/ddraw/clipper.c
@@ -111,7 +111,7 @@ static ULONG WINAPI ddraw_clipper_Release(IDirectDrawClipper *iface)
             DeleteObject(clipper->region);
         /* make sure the object is no longer considered valid */
         SecureZeroMemory( &clipper->IDirectDrawClipper_iface.lpVtbl,
-                          sizeof(clipper->IDirectDrawClipper_iface.lpVtbl) );
+                          sizeof(*clipper->IDirectDrawClipper_iface.lpVtbl) );
         free(clipper);
     }
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6162

[PATCH 1/1] ddraw: SecureZeroMemory did not reset entire size obj, only size ptr

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=147366

Your paranoid android.


=== debian11 (32 bit report) ===

ddraw:
ddraw4.c:18288: Test failed: Failed to create a ddraw object.

Report validation errors:
ddraw:ddraw1 crashed (c0000005)
ddraw:ddraw2 crashed (c0000005)

=== debian11b (64 bit WoW report) ===

ddraw:
ddraw4.c:18288: Test failed: Failed to create a ddraw object.

Report validation errors:
d3drm:d3drm crashed (c0000005)
ddraw:ddraw4 crashed (c0000005)
ddraw:ddraw7 crashed (c0000005)
quartz:filtergraph crashed (c0000005)
quartz:vmr7 crashed (c0000005)

[Zhiyi Zhang (＠zhiyi)]

There is no error here. The original commit is 540219df966edc35d29a6be6fc2beebb92c3b7d6. It's the lpVtbl pointer getting zeroed, not the virtual table that lpVtbl points to.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6162#note_77098

[Herman Semenov (＠GermanAizek)]

On Fri Jul 26 01:51:40 2024 +0000, Zhiyi Zhang wrote:
> There is no error here. The original commit is
> 540219df966edc35d29a6be6fc2beebb92c3b7d6. It's the lpVtbl pointer
> getting zeroed, not the virtual table that lpVtbl points to.
> @zhiyi okay, I'm closing PR

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6162#note_77101

[PATCH 0/1] MR6162: ddraw: SecureZeroMemory did not reset to zero entire size obj, only size ptr - closed

[Herman Semenov (＠GermanAizek)]

This merge request was closed by Herman Semenov.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6162

[Zhiyi Zhang (＠zhiyi)]

On Fri Jul 26 01:51:40 2024 +0000, Herman Semenov wrote:
> @zhiyi okay, I'm closing PR
> You might be getting false positive reports from some static analysis tool. Please make sure the code is understood before filing a fix.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6162#note_77103