[PATCH 0/1] MR9669: winegstreamer: Fix SetOutputType of the wma decoder DMO.
In 60d5afc914e6e5aaee96022834a7f0d5f6a38e94 I moved transform creation to before the decoder->output_type is set, resulting in the decoder trying to create wg_transform with an empty type. bug introduced in !9570. 😖 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9669
From: Yuxuan Shui <yshui(a)codeweavers.com> In 60d5afc914e6e5aaee96022834a7f0d5f6a38e94 I moved transform creation to before the decoder->output_type is set, resulting in the decoder trying to create wg_transform with an empty type. --- dlls/winegstreamer/wma_decoder.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/winegstreamer/wma_decoder.c b/dlls/winegstreamer/wma_decoder.c index 951a50f7164..4aa90b85c6b 100644 --- a/dlls/winegstreamer/wma_decoder.c +++ b/dlls/winegstreamer/wma_decoder.c @@ -798,8 +798,7 @@ static HRESULT WINAPI media_object_SetOutputType(IMediaObject *iface, DWORD inde if (IsEqualGUID(&decoder->input_type.majortype, &GUID_NULL)) return DMO_E_TYPE_NOT_SET; - if (FAILED(hr = wg_transform_create_quartz(&decoder->input_type, &decoder->output_type, - &attrs, &new_transform))) + if (FAILED(hr = wg_transform_create_quartz(&decoder->input_type, type, &attrs, &new_transform))) return hr; if (flags & DMO_SET_TYPEF_TEST_ONLY) -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/9669
This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9669
This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9669
participants (4)
-
Elizabeth Figura (@zfigura) -
Rémi Bernon -
Yuxuan Shui -
Yuxuan Shui (@yshui)