[PATCH 0/1] MR5525: shell32/shellpath: fix UserPinned and QuickLaunch KnownFolderPaths.

[Michael Bond (＠michael.bond)]

Fix for latest autodesk [fusion360 installer](https://github.com/cryinkfly/Autodesk-Fusion-360-for-Linux/issues/408) calling SHGetKnownFolderPath against [FOLDERID_UserPinned](https://learn.microsoft.com/lv-lv/windows/win32/shell/knownfolderid) 

Trace Output pre-patch:
```
15285.659:057c:05c0:trace:shell:SHGetKnownFolderPath {9e3995ab-1f9c-4f13-b827-48b24b6c7174}, 0x00000000, 0000000000000000, 0000000003FB0D98
15285.659:057c:05c0:trace:shell:SHGetFolderPathAndSubDirW 0000000000000000,0x6c,0000000000000000,0,(null),000000000410E3F0
15285.659:057c:05c0:trace:shell:SHGetFolderPathAndSubDirW returning 0x80070057 (final path is L"")
15285.659:057c:05c0:trace:shell:SHGetKnownFolderPath Failed to get folder path, 0x80070057.
15285.659:057c:05c0:Ret  shell32.SHGetKnownFolderPath() retval=80070057 ret=6ffff9774771
```

SHGetFolderPathAndSubDirW returns 0x57 invalid-parameter error (0x80070057) due to the folder array in shell32/shellpath.c having CSIDL_Type_Disallowed set on UserPinned and QuickLaunch folders.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5525

[PATCH 1/1] shell32/shellpath: fix UserPinned and QuickLaunch KnownFolderPaths.

[Michael Bond]

From: Michael Bond <michael.bond(a)posteo.de>

---
 dlls/shell32/shellpath.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c
index e32bf5a50dc..7fbded5743b 100644
--- a/dlls/shell32/shellpath.c
+++ b/dlls/shell32/shellpath.c
@@ -1722,7 +1722,7 @@ static const CSIDL_DATA CSIDL_Data[] =
     },
     { /* 0x4b */
         .id         = &FOLDERID_ImplicitAppShortcuts,
-        .type       = CSIDL_Type_Disallowed, /* FIXME */
+        .type       = CSIDL_Type_User,
         .category   = KF_CATEGORY_PERUSER,
         .name       = L"ImplicitAppShortcuts",
         .parent     = &FOLDERID_UserPinned,
@@ -1878,7 +1878,7 @@ static const CSIDL_DATA CSIDL_Data[] =
     },
     { /* 0x5b */
         .id         = &FOLDERID_QuickLaunch,
-        .type       = CSIDL_Type_Disallowed, /* FIXME */
+        .type       = CSIDL_Type_User,
         .category   = KF_CATEGORY_PERUSER,
         .name       = L"Quick Launch",
         .parent     = &FOLDERID_RoamingAppData,
@@ -2024,7 +2024,7 @@ static const CSIDL_DATA CSIDL_Data[] =
     },
     { /* 0x6c */
         .id         = &FOLDERID_UserPinned,
-        .type       = CSIDL_Type_Disallowed, /* FIXME */
+        .type       = CSIDL_Type_User,
         .category   = KF_CATEGORY_PERUSER,
         .name       = L"User Pinned",
         .parent     = &FOLDERID_QuickLaunch,
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5525