[PATCH 0/1] MR1341: ntdll: Make the "not found" trace in nt_to_unix_file_name_no_root() less misleading.
unix_name is not guaranteed to be zero-terminated at this point. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1341
From: Zebediah Figura <zfigura(a)codeweavers.com> unix_name is not guaranteed to be zero-terminated at this point. --- dlls/ntdll/unix/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/unix/file.c b/dlls/ntdll/unix/file.c index 6b73d9dc7e8..44ff136c423 100644 --- a/dlls/ntdll/unix/file.c +++ b/dlls/ntdll/unix/file.c @@ -3540,7 +3540,7 @@ static NTSTATUS nt_to_unix_file_name_no_root( const UNICODE_STRING *nameW, char } else { - TRACE( "%s not found in %s\n", debugstr_w(name), unix_name ); + TRACE( "%s not found in %s\n", debugstr_w(name), debugstr_an(unix_name, pos) ); free( unix_name ); } return status; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/1341
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=126110 Your paranoid android. === debian11 (32 bit report) === ole32: clipboard.c:1067: Test failed: OleIsCurrentClipboard returned 0 clipboard.c:1135: Test failed: 1 WM_DRAWCLIPBOARD received
participants (3)
-
Marvin -
Zebediah Figura -
Zebediah Figura (@zfigura)