Re: [PATCH v6 0/4] MR5161: d3drm: Implement Update and related functions

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/d3drm/tests/d3drm.c:
> +    todo_wine ok(hr == D3DRM_OK, "Cannot force update of viewport, hr %#lx.\n", hr);
> +    hr = IDirect3DRMDevice_AddUpdateCallback(device1, update_cb_modify_rect, NULL);
> +    todo_wine ok(hr == D3DRM_OK, "Cannot add update callback, hr %#lx.\n", hr);
> +    hr = IDirect3DRMDevice_AddUpdateCallback(device1, update_cb_get_rect, &ctx);
> +    todo_wine ok(hr == D3DRM_OK, "Cannot add update callback, hr %#lx.\n", hr);
> +    hr = IDirect3DRMDevice_Update(device1);
> +    ok(hr == D3DRM_OK, "Cannot update Direct3DRMDevice, hr %#lx.\n", hr);
> +    hr = IDirect3DRMDevice_DeleteUpdateCallback(device1, update_cb_modify_rect, NULL);
> +    todo_wine ok(hr == D3DRM_OK, "Cannot delete update callback, hr %#lx.\n", hr);
> +    hr = IDirect3DRMDevice_DeleteUpdateCallback(device1, update_cb_get_rect, &ctx);
> +    todo_wine ok(hr == D3DRM_OK, "Cannot delete update callback, hr %#lx.\n", hr);
> +    todo_wine ok(ctx.rect_count == 1, "Got unexpected rect count %d, expected 1.\n", ctx.rect_count);
> +    todo_wine
> +    ok(ctx.rect.x1 == 999999 && ctx.rect.y1 <= vrect.top &&
> +       ctx.rect.x2 >= vrect.right && ctx.rect.y2 >= vrect.bottom,
> +            "Got unexpected rect %s.\n", wine_dbgstr_rect((RECT *)&ctx.rect));
> Any reason not to test the exact values?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5161#note_63578