[PATCH 0/1] MR4660: gdiplus: Fix invalid pointer returned when failing to create font

[Hans Lehnert (＠hanslehnert)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4660

[PATCH 1/1] gdiplus: Fix invalid pointer returned when failing to create font

[Hans Lehnert]

From: Hans Lehnert <hans.lehnert(a)gmail.com>

---
 dlls/gdiplus/font.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/gdiplus/font.c b/dlls/gdiplus/font.c
index 4970043eb15..0dcfad34bbb 100644
--- a/dlls/gdiplus/font.c
+++ b/dlls/gdiplus/font.c
@@ -236,6 +236,7 @@ GpStatus WINGDIPAPI GdipCreateFontFromLogfontW(HDC hdc,
     if (stat != Ok)
     {
         free(*font);
+        *font = NULL;
         return NotTrueTypeFont;
     }
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4660

[David Kahurani (＠kahurani)]

Hi,

It would be great if you included a test for this.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4660#note_55598

[PATCH 0/1] MR4660: gdiplus: Fix invalid pointer returned when failing to create font - approved

[Esme Povirk (＠madewokherd)]

This merge request was approved by Esme Povirk.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4660

[Hans Lehnert (＠hanslehnert)]

On Mon Dec 11 00:49:45 2023 +0000, David Kahurani wrote:
> Hi,
> It would be great if you included a test for this.
> I think testing might not be straightforward as it would require some font that's not supported and will reach this code path to always be installed.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4660#note_55659