[PATCH 0/2] MR5416: makedep: Add import and static libs to all.

[Rémi Bernon]

They are otherwise only built during `make install` which doesn't seem right.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5416

[PATCH 1/2] makedep: Add import libs to the all target.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

---
 tools/makedep.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/makedep.c b/tools/makedep.c
index 8ce575b15ca..05063670163 100644
--- a/tools/makedep.c
+++ b/tools/makedep.c
@@ -3420,6 +3420,7 @@ static void output_import_lib( struct makefile *make, unsigned int arch )
     char *spec_file = src_dir_path( make, replace_extension( make->module, ".dll", ".spec" ));
     const char *name = strmake( "%slib%s.a", arch_dirs[arch], make->importlib );
 
+    strarray_add( &make->all_targets[arch], name );
     strarray_add( &make->clean_files, name );
     if (needs_delay_lib( make, arch ))
     {
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/5416

[PATCH 2/2] makedep: Add static libs to the all target.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

---
 tools/makedep.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/makedep.c b/tools/makedep.c
index 05063670163..c9fdf5ef648 100644
--- a/tools/makedep.c
+++ b/tools/makedep.c
@@ -3490,8 +3490,11 @@ static void output_static_lib( struct makefile *make, unsigned int arch )
     if (!arch) output_filenames_obj_dir( make, make->unixobj_files );
     output( "\n" );
     if (!make->extlib)
+    {
         add_install_rule( make, make->staticlib, arch, name,
                           strmake( "d%s%s", arch_install_dirs[arch], make->staticlib ));
+        strarray_add( &make->all_targets[arch], name );
+    }
 }
 
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5416

[Alexandre Julliard (＠julliard)]

That's on purpose, because they are slow to build and not needed for most use cases.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5416#note_66369

[PATCH 0/2] MR5416: makedep: Add import and static libs to all. - closed

[Rémi Bernon]

This merge request was closed by Rémi Bernon.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5416

[Rémi Bernon]

I see, nvm then

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5416#note_66371