[PATCH 0/1] MR1449: msado15: Avoid uninitialized variable use in fields_get_Item

[Gerald Pfeifer (＠gerald)]

This avoids the following warning by GCC 13:

dlls/msado15/recordset.c:790:32: warning: 'i' may be used uninitialized

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1449

[PATCH 1/1] msado15: Avoid uninitialized variable use in fields_get_Item

[Gerald Pfeifer]

From: Gerald Pfeifer <gerald(a)pfeifer.com>

This avoids the following warning by GCC 13:
  dlls/msado15/recordset.c:790:32: warning: 'i' may be used uninitialized
---
 dlls/msado15/recordset.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/dlls/msado15/recordset.c b/dlls/msado15/recordset.c
index 177938af2f7..0aba2b9c7c0 100644
--- a/dlls/msado15/recordset.c
+++ b/dlls/msado15/recordset.c
@@ -764,7 +764,11 @@ static HRESULT map_index( struct fields *fields, VARIANT *index, ULONG *ret )
         BOOL match;
         HRESULT hr;
 
-        if ((hr = Field_get_Name( fields->field[i], &name )) != S_OK) return hr;
+        if ((hr = Field_get_Name( fields->field[i], &name )) != S_OK)
+        {
+            *ret = 0;
+            return hr;
+        }
         match = !wcsicmp( V_BSTR( index ), name );
         SysFreeString( name );
         if (match)
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1449

[Hans Leidekker (＠hans)]

'i' is always set when map_index() returns success so this is a false positive. It would be cleaner to initialize 'i' in fields_get_Item().

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1449#note_16529