[PATCH 0/1] MR9067: windows.storage: Redirect SHGetKnownFolderPath() to shell32.

[Andrey Gusev (＠agusev)]

Fixes a crash with GamingRepair for Senua's Saga: Hellblade II.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9067

[PATCH 1/1] windows.storage: Redirect SHGetKnownFolderPath() to shell32.

[Andrey Gusev]

From: Andrey Gusev <andrey.goosev(a)gmail.com>

---
 dlls/windows.storage/windows.storage.spec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/windows.storage/windows.storage.spec b/dlls/windows.storage/windows.storage.spec
index 365a1ab8ceb..6eec39a0752 100644
--- a/dlls/windows.storage/windows.storage.spec
+++ b/dlls/windows.storage/windows.storage.spec
@@ -244,7 +244,7 @@
 @ stub SHGetKnownFolderIDList
 @ stub SHGetKnownFolderIDList_Internal
 @ stub SHGetKnownFolderItem
-@ stub SHGetKnownFolderPath
+@ stdcall SHGetKnownFolderPath(ptr long ptr ptr) shell32.SHGetKnownFolderPath
 @ stub SHGetNameFromIDList
 @ stub SHGetPathFromIDListEx
 @ stub SHGetPathFromIDListW
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9067

[Paul Gofman (＠gofman)]

Does it exactly a forward / redirect on Windows? As I read winedump output, it is not. In this case, I guess it might still be possible to temporary fix things by redirecting the function to shell32, even if that is the other way around on Windows, but I think it is better to use '@stdcall -import' way instead of forward. The latter is known to trip various hotpatchers and DRMs querying exports, so unless it is the same on Windows is best avoided.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9067#note_117052