[PATCH 0/1] MR4734: gdiplus: Avoid use of temporary variable

[David Kahurani (＠kahurani)]

A temporary variable is used here to assist with assignment
but this does not conform to the coding style in the rest of
gdiplus and introduces an unnecessary variable.

Signed-off-by: David Kahurani <k.kahurani(a)gmail.com>

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4734

[PATCH 1/1] gdiplus: Avoid use of temporary variable

[David Kahurani]

From: David Kahurani <k.kahurani(a)gmail.com>

A temporary variable is used here to assist with assignment
but this does not conform to the coding style in the rest of
gdiplus and introduces an unnecessary variable.

Signed-off-by: David Kahurani <k.kahurani(a)gmail.com>
---
 dlls/gdiplus/graphicspath.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/dlls/gdiplus/graphicspath.c b/dlls/gdiplus/graphicspath.c
index 24c2888cfe8..9e186aa43d1 100644
--- a/dlls/gdiplus/graphicspath.c
+++ b/dlls/gdiplus/graphicspath.c
@@ -117,10 +117,16 @@ struct flatten_bezier_job
 static BOOL flatten_bezier_add(struct list *jobs, path_list_node_t *start, REAL x2, REAL y2, REAL x3, REAL y3, path_list_node_t *end)
 {
     struct flatten_bezier_job *job = malloc(sizeof(struct flatten_bezier_job));
-    struct flatten_bezier_job temp = { start, x2, y2, x3, y3, end };
     if (!job)
         return FALSE;
-    *job = temp;
+
+    job->start = start;
+    job->x2 = x2;
+    job->y2 = y2;
+    job->x3 = x3;
+    job->y3 = y3;
+    job->end = end;
+
     list_add_after(jobs, &job->entry);
     return TRUE;
 }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4734

[Esme Povirk (＠madewokherd)]

I'm not convinced this is more efficient in practice, but it doesn't decrease the readability so I guess it's fine.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4734#note_56405

[PATCH 0/1] MR4734: gdiplus: Avoid use of temporary variable - approved

[Esme Povirk (＠madewokherd)]

This merge request was approved by Esme Povirk.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4734