[PATCH 0/1] MR8822: d3dx10_43: Fix test for SDK version 40.

[Bernhard Übelacker]

Followup to: 3e67471d02

Looks like this sould be a >= as it affects just d3dx10_40, at least with it the test succeeds on testbot.

[Test pattern page](https://test.winehq.org/data/patterns.html#d3dx10_40:d3dx10)

[Test pattern page, Aug 21 Summary for build e155f7c04b7c](https://test.winehq.org/data/e155f7c04b7c529af9e0f64ee3db8ef3f67558b0/#d3dx1...)

[Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=159474)

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8822

[PATCH 1/1] d3dx10_43: Fix test for SDK version 40.

[Bernhard Übelacker]

From: Bernhard Übelacker <bernhardu(a)mailbox.org>

Followup to: 3e67471d02
---
 dlls/d3dx10_43/tests/d3dx10.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/d3dx10_43/tests/d3dx10.c b/dlls/d3dx10_43/tests/d3dx10.c
index ded2940ba46..cd9f6487fc6 100644
--- a/dlls/d3dx10_43/tests/d3dx10.c
+++ b/dlls/d3dx10_43/tests/d3dx10.c
@@ -4382,7 +4382,7 @@ static void test_create_effect_from_memory(void)
     /* Empty buffers are always included before version 40. */
     hr = effect->lpVtbl->GetDesc(effect, &desc);
     ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr);
-#if D3DX10_SDK_VERSION > 40
+#if D3DX10_SDK_VERSION >= 40
     ok(desc.ConstantBuffers == 1, "Unexpected buffer count.\n");
 #else
     todo_wine
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8822

[Nikolay Sivov (＠nsivov)]

Looks good to me.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8822#note_113644

[Bernhard Übelacker]

Got committed as part of 1acc0f2b4e3.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8822#note_113832

[PATCH 0/1] MR8822: d3dx10_43: Fix test for SDK version 40. - closed

[Bernhard Übelacker]

This merge request was closed by Bernhard Übelacker.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8822

[Nikolay Sivov (＠nsivov)]

On Tue Aug 26 09:02:48 2025 +0000, Bernhard Übelacker wrote:
> Got committed as part of 1acc0f2b4e3.
> Oh, sorry about that. That wasn't intentional, I just pushed it together with my branch.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8822#note_113835

[Bernhard Übelacker]

On Tue Aug 26 09:02:48 2025 +0000, Nikolay Sivov wrote:
> Oh, sorry about that. That wasn't intentional, I just pushed it together
> with my branch.
> No problem, just wondered why the test started to succeed.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8822#note_113836