Re: [PATCH v19 0/16] MR3870: mspatcha: Add support for 32-bit file patching and normalization
20 Sep
2023
20 Sep
'23
6:27 p.m.
On Tue Sep 19 18:27:47 2023 +0000, Aidan Khoury wrote:
This is needed in case the `-Wunused-variable` is used with clang compiler frontend. The Windows Patch API passes this variable - see https://learn.microsoft.com/en-us/previous-versions/bb417345(v=msdn.10)#norm.... Though it is unused, I would like to keep it to maintain compatibility with the Windows API. I assume you mean -Wunused-parameter, since -Wunused-variable alone shouldn't warn on parameters.
I don't think -Wunused-parameter is reasonable to enable for Wine. The Windows API has far, far too many unused parameters for annotating them all to be worthwhile. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46053
899
Age (days ago)
899
Last active (days ago)
0 comments
1 participants
participants (1)
-
Zebediah Figura (@zfigura)