[PATCH 0/1] MR913: winegstreamer: Avoid accessing NULL pointer if transform didn't provide a sample.

[Rémi Bernon]

This can happen with asynchronous decoding, such as with the VA-API
decodebin plugin for H264.

This fixes the mf transform tests crashing when VA-API plugins are used.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/913

[PATCH 1/1] winegstreamer: Avoid accessing NULL pointer if transform didn't provide a sample.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

This can happen with asynchronous decoding, such as with the VA-API
decodebin plugin for H264.
---
 dlls/winegstreamer/wg_allocator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/winegstreamer/wg_allocator.c b/dlls/winegstreamer/wg_allocator.c
index 5b2c48dcf77..784677e2b2d 100644
--- a/dlls/winegstreamer/wg_allocator.c
+++ b/dlls/winegstreamer/wg_allocator.c
@@ -164,7 +164,7 @@ static GstMemory *wg_allocator_alloc(GstAllocator *gst_allocator, gsize size,
     pthread_mutex_lock(&allocator->mutex);
 
     sample = allocator->request_sample(size, allocator->request_sample_context);
-    if (sample->max_size < size)
+    if (sample && sample->max_size < size)
         InterlockedDecrement(&sample->refcount);
     else
         memory->sample = sample;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/913

[PATCH 0/1] MR913: winegstreamer: Avoid accessing NULL pointer if transform didn't provide a sample. - approved

[Zebediah Figura (＠zfigura)]

This merge request was approved by Zebediah Figura.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/913