Re: [PATCH v4 0/5] MR2483: kernelbase: Add full support for shared Software\Classes keys.

[Alexandre Julliard (＠julliard)]

Alexandre Julliard (@julliard) commented about dlls/kernelbase/registry.c:
> return (len >= 11 && !wcsnicmp( name->Buffer, L"Wow6432Node\\", min( len, 12 ) ));
>  }
>
> -/* open the Wow6432Node subkey of the specified key */
> +static BOOL is_classes_root( const UNICODE_STRING *name )
> +{
> +    return (name->Length >= wcslen(root_key_names[0]) * sizeof(WCHAR) && !wcsnicmp( name->Buffer, root_key_names[0], wcslen(root_key_names[0]) ));

You again have to check the string terminator, matching a substring is not sufficient.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2483#note_27986