Re: [PATCH v4 0/5] MR8244: combase: Add RoFailFastWithErrorContextInternal2() stub.
11 Jun
2025
11 Jun
'25
1:10 a.m.
On Tue Jun 10 23:46:26 2025 +0000, Jinoh Kang wrote:
Thanks for your insight. I understand, but IMHO it's a good idea not to include generated files since they introduce unnecessary merge conflicts. For example, adding a new syscall results in about half of `dlls/ntdll/ntsyscalls.h` to be rewritten. MRs that (1) add a syscall, and (2) include generated files will surely conflict each other. But the patch is going to be edited before committing anyway, whether the generated changes are included or not, so I don't see the issue?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8244#note_106184
190
Age (days ago)
190
Last active (days ago)
0 comments
1 participants
participants (1)
-
Elizabeth Figura (@zfigura)