[PATCH 0/1] MR2534: dmsynth: Don't crash when Open() gets a DMUS_PORTPARAMS7

[Michael Stefaniuc (＠mstefani)]

Wrong sizeof check: pointer instead of referenced structure.

Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=53704

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2534

[PATCH 1/1] dmsynth: Don't crash when Open() gets a DMUS_PORTPARAMS7

[Michael Stefaniuc]

From: Michael Stefaniuc <mstefani(a)winehq.org>

Wrong sizeof check: pointer instead of referenced structure.

Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=53704
---
 dlls/dmsynth/synth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/dmsynth/synth.c b/dlls/dmsynth/synth.c
index 121d9aadf35..3631bcfe784 100644
--- a/dlls/dmsynth/synth.c
+++ b/dlls/dmsynth/synth.c
@@ -163,7 +163,7 @@ static HRESULT WINAPI IDirectMusicSynth8Impl_Open(IDirectMusicSynth8 *iface, DMU
         modified = TRUE;
     params->fShare = FALSE;
 
-    if (params->dwSize >= sizeof(params)) {
+    if (params->dwSize >= sizeof(*params)) {
         if (params->dwValidParams & DMUS_PORTPARAMS_FEATURES && params->dwFeatures) {
             if (params->dwFeatures & ~(DMUS_PORT_FEATURE_AUDIOPATH|DMUS_PORT_FEATURE_STREAMING)) {
                 modified = TRUE;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2534

[PATCH 0/1] MR2534: dmsynth: Don't crash when Open() gets a DMUS_PORTPARAMS7 - approved

[Etaash Mathamsetty (＠etaash.mathamsetty)]

This merge request was approved by Etaash Mathamsetty.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2534