Re: [PATCH v10 0/6] MR8831: vccorlib140: Implement support for boxed values (aka IPropertyValue)

[Bernhard Übelacker]

On Sun Aug 31 11:46:59 2025 +0000, Vibhav Pant wrote:
> Yes, I think `IPropertyValueStatics::CreateString` should use
> `WindowsDuplicateString`. Could you replace the code
> [here](https://gitlab.winehq.org/wine/wine/-/blob/1d1e5fb3e51b2acb0143e86c16463dfed...)
> with
> ```c
> {
>     HSTRING value;
>     HRESULT hr;
>     TRACE("iface %p, value %s, property_value %p.\n", iface,
> debugstr_hstring(value_str), property_value);
>     *property_value = NULL;
>     if (FAILED(hr = WindowsDuplicateString(value_str, &value))) return hr;
>     create_primitive_property_value_iref(PropertyType_String,
> irefs.hstring_iface.lpVtbl, iref_hstring_vtbl);
> }
> ```
> and see if it resolves the issue? I'll create an MR in that case.
> Thanks for looking into it. By replacing the body of property_value_statics_CreateString with above version (and renaming the parameter value to value_str) ASan stays silent and the test succeeds here.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8831#note_114358