[PATCH 0/1] MR8919: ntdll: Fix the build of check_invalid_gsbase() on FreeBSD

[Gerald Pfeifer (＠gerald)]

This addresses

  dlls/ntdll/unix/signal_x86_64.c: In function ‘check_invalid_gsbase’:
  dlls/ntdll/unix/signal_x86_64.c:2067:23: error: passing argument 1 of ‘amd64_get_gsbase’ from incompatible pointer type [-Wincompatible-pointer-types]
   2067 |     amd64_get_gsbase( &cur_gsbase );
        |                       ^~~~~~~~~~~
        |                       |
        |                       ULONG_PTR * {aka long unsigned int *}

which shows with modern compilers.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8919

[PATCH 1/1] ntdll: Fix the build of check_invalid_gsbase() on FreeBSD

[Gerald Pfeifer]

From: Gerald Pfeifer <gerald(a)pfeifer.com>

This addresses

  dlls/ntdll/unix/signal_x86_64.c: In function ‘check_invalid_gsbase’:
  dlls/ntdll/unix/signal_x86_64.c:2067:23: error: passing argument 1 of ‘amd64_get_gsbase’ from incompatible pointer type [-Wincompatible-pointer-types]
   2067 |     amd64_get_gsbase( &cur_gsbase );
        |                       ^~~~~~~~~~~
        |                       |
        |                       ULONG_PTR * {aka long unsigned int *}

which shows with modern compilers.
---
 dlls/ntdll/unix/signal_x86_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/ntdll/unix/signal_x86_64.c b/dlls/ntdll/unix/signal_x86_64.c
index b64d9ac648c..866de0f5f89 100644
--- a/dlls/ntdll/unix/signal_x86_64.c
+++ b/dlls/ntdll/unix/signal_x86_64.c
@@ -2064,7 +2064,7 @@ static inline BOOL check_invalid_gsbase( ucontext_t *ucontext )
     else
         arch_prctl( ARCH_GET_GS, &cur_gsbase );
 #elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
-    amd64_get_gsbase( &cur_gsbase );
+    amd64_get_gsbase( (void**)&cur_gsbase );
 #elif defined(__NetBSD__)
     sysarch( X86_64_GET_GSBASE, &cur_gsbase );
 #elif defined(__APPLE__)
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8919