[PATCH 0/1] MR9175: mfplat/tests: Fix a crash on some Windows systems.

[Nikolay Sivov (＠nsivov)]

It appears that EndCreateObjectFromURL() clears object pointer carried by
the result object. Existing test is likely hitting implementation details.

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9175

[PATCH 1/1] mfplat/tests: Fix a crash on some Windows systems.

[Nikolay Sivov]

From: Nikolay Sivov <nsivov(a)codeweavers.com>

It appears that EndCreateObjectFromURL() clears object pointer carried by
the result object. Existing test is likely hitting implementation details.

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>
---
 dlls/mfplat/tests/mfplat.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/dlls/mfplat/tests/mfplat.c b/dlls/mfplat/tests/mfplat.c
index 21bcc86c8d1..70f0d9f6a3a 100644
--- a/dlls/mfplat/tests/mfplat.c
+++ b/dlls/mfplat/tests/mfplat.c
@@ -891,8 +891,8 @@ static HRESULT WINAPI test_create_from_url_callback_Invoke(IMFAsyncCallback *ifa
 {
     struct test_callback *callback = impl_from_IMFAsyncCallback(iface);
     IMFSourceResolver *resolver;
-    IUnknown *object, *object2;
     MF_OBJECT_TYPE obj_type;
+    IUnknown *object;
     HRESULT hr;
 
     ok(!!result, "Unexpected result object.\n");
@@ -903,13 +903,8 @@ static HRESULT WINAPI test_create_from_url_callback_Invoke(IMFAsyncCallback *ifa
     hr = IMFSourceResolver_EndCreateObjectFromURL(resolver, result, &obj_type, &object);
     ok(hr == S_OK, "Failed to create an object, hr %#lx.\n", hr);
 
-    hr = IMFAsyncResult_GetObject(result, &object2);
-    ok(hr == S_OK, "Failed to get result object, hr %#lx.\n", hr);
-    ok(object2 == object, "Unexpected object.\n");
-
     if (object)
         IUnknown_Release(object);
-    IUnknown_Release(object2);
 
     SetEvent(callback->event);
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9175