[PATCH 0/1] MR3663: mpr: Fix double free in WNetGetResourceInformationA.

[Alex Henrie (＠alexhenrie)]

Necessary before switching to CRT allocation functions because GCC warns about it after switching.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3663

[PATCH 1/1] mpr: Fix double free in WNetGetResourceInformationA.

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

---
 dlls/mpr/wnet.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/dlls/mpr/wnet.c b/dlls/mpr/wnet.c
index 999a2a0e80c..e9c5321cee1 100644
--- a/dlls/mpr/wnet.c
+++ b/dlls/mpr/wnet.c
@@ -1684,7 +1684,7 @@ DWORD WINAPI WNetGetResourceInformationA( LPNETRESOURCEA lpNetResource,
         if (ret == WN_SUCCESS)
         {
             LPWSTR lpSystemW = NULL;
-            LPVOID lpBufferW;
+            NETRESOURCEW *lpBufferW;
             size = 1024;
             lpBufferW = HeapAlloc(GetProcessHeap(), 0, size);
             if (lpBufferW)
@@ -1705,12 +1705,10 @@ DWORD WINAPI WNetGetResourceInformationA( LPNETRESOURCEA lpNetResource,
                 {
                     ret = _thunkNetResourceArrayWToA(lpBufferW,
                             &count, lpBuffer, cbBuffer);
-                    HeapFree(GetProcessHeap(), 0, lpNetResourceW);
-                    lpNetResourceW = lpBufferW;
                     size = sizeof(NETRESOURCEA);
-                    size += WideCharToMultiByte(CP_ACP, 0, lpNetResourceW->lpRemoteName,
+                    size += WideCharToMultiByte(CP_ACP, 0, lpBufferW->lpRemoteName,
                             -1, NULL, 0, NULL, NULL);
-                    size += WideCharToMultiByte(CP_ACP, 0, lpNetResourceW->lpProvider,
+                    size += WideCharToMultiByte(CP_ACP, 0, lpBufferW->lpProvider,
                             -1, NULL, 0, NULL, NULL);
 
                     len = WideCharToMultiByte(CP_ACP, 0, lpSystemW,
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3663